From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by kanga.kvack.org (Postfix) with ESMTP id 5E3578E0002 for ; Tue, 15 Jan 2019 08:50:53 -0500 (EST) Received: by mail-pf1-f199.google.com with SMTP id x67so1963867pfk.16 for ; Tue, 15 Jan 2019 05:50:53 -0800 (PST) Received: from suse.de (nat.nue.novell.com. [2620:113:80c0:5::2222]) by mx.google.com with ESMTP id b3si3296604pgh.496.2019.01.15.05.50.51 for ; Tue, 15 Jan 2019 05:50:52 -0800 (PST) Date: Tue, 15 Jan 2019 14:50:49 +0100 From: Oscar Salvador Subject: Re: [PATCH] mm, memory_hotplug: __offline_pages fix wrong locking Message-ID: <20190115135042.qxu2yoy3zs2fs6cy@d104.suse.de> References: <20190115120307.22768-1-mhocko@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190115120307.22768-1-mhocko@kernel.org> Sender: owner-linux-mm@kvack.org List-ID: To: Michal Hocko Cc: Andrew Morton , Jan Kara , Oscar Salvador , Anshuman Khandual , linux-mm@kvack.org, LKML , Michal Hocko On Tue, Jan 15, 2019 at 01:03:07PM +0100, Michal Hocko wrote: > From: Michal Hocko > > Jan has noticed that we do double unlock on some failure paths when > offlining a page range. This is indeed the case when test_pages_in_a_zone > respp. start_isolate_page_range fail. This was an omission when forward > porting the debugging patch from an older kernel. > > Fix the issue by dropping mem_hotplug_done from the failure condition > and keeping the single unlock in the catch all failure path. > > Reported-by: Jan Kara > Fixes: 7960509329c2 ("mm, memory_hotplug: print reason for the offlining failure") > Signed-off-by: Michal Hocko Uhmf, I overlooked that while reviewing the patch. Reviewed-by: Oscar Salvador Thanks -- Oscar Salvador SUSE L3