From: Matthew Wilcox <willy@infradead.org>
To: Qian Cai <cai@lca.pw>
Cc: akpm@linux-foundation.org, esploit@protonmail.ch,
jejb@linux.ibm.com, dgilbert@interlog.com,
martin.petersen@oracle.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, walken@google.com,
David.Woodhouse@intel.com
Subject: Re: [PATCH] rbtree: fix the red root
Date: Fri, 11 Jan 2019 10:16:00 -0800 [thread overview]
Message-ID: <20190111181600.GJ6310@bombadil.infradead.org> (raw)
In-Reply-To: <1547230356.6911.23.camel@lca.pw>
On Fri, Jan 11, 2019 at 01:12:36PM -0500, Qian Cai wrote:
> On Fri, 2019-01-11 at 09:31 -0800, Matthew Wilcox wrote:
> > On Fri, Jan 11, 2019 at 11:51:45AM -0500, Qian Cai wrote:
> > > Reported-by: Esme <esploit@protonmail.ch>
> > > Signed-off-by: Qian Cai <cai@lca.pw>
> >
> > What change introduced this bug?��We need a Fixes: line so the stable
> > people know how far to backport this fix.
>
> It looks like,
>
> Fixes: 6d58452dc06 (rbtree: adjust root color in rb_insert_color() only when
> necessary)
>
> where it no longer always paint the root as black.
>
> Also, copying this fix for the original author and reviewer.
>
> https://lore.kernel.org/lkml/20190111165145.23628-1-cai@lca.pw/
Great, thanks! We have a test-suite (lib/rbtree_test.c); could you add
a test to it that will reproduce this bug without your patch applied?
WARNING: multiple messages have this Message-ID
From: Matthew Wilcox <willy@infradead.org>
To: Qian Cai <cai@lca.pw>
Cc: akpm@linux-foundation.org, esploit@protonmail.ch,
jejb@linux.ibm.com, dgilbert@interlog.com,
martin.petersen@oracle.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, walken@google.com,
David.Woodhouse@intel.com
Subject: Re: [PATCH] rbtree: fix the red root
Date: Fri, 11 Jan 2019 10:16:00 -0800 [thread overview]
Message-ID: <20190111181600.GJ6310@bombadil.infradead.org> (raw)
Message-ID: <20190111181600.ELTYkgvh64vko1ggxiTGzHncAvJmTDbjzm7i7P03QxQ@z> (raw)
In-Reply-To: <1547230356.6911.23.camel@lca.pw>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="UTF-8", Size: 845 bytes --]
On Fri, Jan 11, 2019 at 01:12:36PM -0500, Qian Cai wrote:
> On Fri, 2019-01-11 at 09:31 -0800, Matthew Wilcox wrote:
> > On Fri, Jan 11, 2019 at 11:51:45AM -0500, Qian Cai wrote:
> > > Reported-by: Esme <esploit@protonmail.ch>
> > > Signed-off-by: Qian Cai <cai@lca.pw>
> >
> > What change introduced this bug? We need a Fixes: line so the stable
> > people know how far to backport this fix.
>
> It looks like,
>
> Fixes: 6d58452dc06 (rbtree: adjust root color in rb_insert_color() only when
> necessary)
>
> where it no longer always paint the root as black.
>
> Also, copying this fix for the original author and reviewer.
>
> https://lore.kernel.org/lkml/20190111165145.23628-1-cai@lca.pw/
Great, thanks! We have a test-suite (lib/rbtree_test.c); could you add
a test to it that will reproduce this bug without your patch applied?
next prev parent reply other threads:[~2019-01-11 18:16 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <YrcPMrGmYbPe_xgNEV6Q0jqc5XuPYmL2AFSyeNmg1gW531bgZnBGfEUK5_ktqDBaNW37b-NP2VXvlliM7_PsBRhSfB649MaW1Ne7zT9lHc=@protonmail.ch>
2019-01-11 16:51 ` Qian Cai
2019-01-11 17:17 ` Joey Pabalinas
2019-01-11 17:31 ` Matthew Wilcox
2019-01-11 17:53 ` Joey Pabalinas
2019-01-11 18:12 ` Qian Cai
2019-01-11 18:12 ` Qian Cai
2019-01-11 18:16 ` Matthew Wilcox [this message]
2019-01-11 18:16 ` Matthew Wilcox
2019-01-11 20:58 ` [PATCH v2] " Qian Cai
2019-01-11 23:16 ` Matthew Wilcox
2019-01-12 0:18 ` Qian Cai
2019-01-12 0:39 ` Esme
2019-01-11 23:47 ` David Lechner
2019-01-12 2:58 ` Michel Lespinasse
2019-01-12 2:58 ` Michel Lespinasse
2019-01-14 2:20 ` David Lechner
2019-01-14 2:33 ` Qian Cai
2019-01-14 3:07 ` Esme
2019-01-14 3:52 ` Douglas Gilbert
2019-01-14 3:59 ` Esme
2019-01-14 4:52 ` Douglas Gilbert
2019-01-14 6:23 ` Esme
2019-01-14 15:45 ` Qian Cai
2019-01-14 15:51 ` Esme
2019-01-14 17:58 ` Qian Cai
2019-01-14 18:26 ` Douglas Gilbert
2019-01-15 5:31 ` Qian Cai
2019-01-16 14:37 ` Esme
2019-01-18 17:10 ` Qian Cai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190111181600.GJ6310@bombadil.infradead.org \
--to=willy@infradead.org \
--cc=David.Woodhouse@intel.com \
--cc=akpm@linux-foundation.org \
--cc=cai@lca.pw \
--cc=dgilbert@interlog.com \
--cc=esploit@protonmail.ch \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=martin.petersen@oracle.com \
--cc=walken@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox