From: Mel Gorman <mgorman@techsingularity.net>
To: YueHaibing <yuehaibing@huawei.com>
Cc: Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Andrew Morton <akpm@linux-foundation.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Vlastimil Babka <vbabka@suse.cz>, Michal Hocko <mhocko@suse.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH -next] mm, compaction: remove set but not used variables 'a, b, c'
Date: Wed, 9 Jan 2019 10:15:51 +0000 [thread overview]
Message-ID: <20190109101551.GR31517@techsingularity.net> (raw)
In-Reply-To: <1547002967-6127-1-git-send-email-yuehaibing@huawei.com>
On Wed, Jan 09, 2019 at 03:02:47AM +0000, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> mm/compaction.c: In function 'compact_zone':
> mm/compaction.c:2063:22: warning:
> variable 'c' set but not used [-Wunused-but-set-variable]
> mm/compaction.c:2063:19: warning:
> variable 'b' set but not used [-Wunused-but-set-variable]
> mm/compaction.c:2063:16: warning:
> variable 'a' set but not used [-Wunused-but-set-variable]
>
> This never used since 94d5992baaa5 ("mm, compaction: finish pageblock
> scanning on contention")
>
Dang. This is left-over debugging code that got accidentally merged
during a rebase. Andrew, can you pick this up as a fix to the mmotm
patch mm-compaction-finish-pageblock-scanning-on-contention.patch please?
Thanks YueHaibing.
--
Mel Gorman
SUSE Labs
prev parent reply other threads:[~2019-01-09 10:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-09 3:02 YueHaibing
2019-01-09 3:02 ` YueHaibing
2019-01-09 10:15 ` Mel Gorman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190109101551.GR31517@techsingularity.net \
--to=mgorman@techsingularity.net \
--cc=akpm@linux-foundation.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=sfr@canb.auug.org.au \
--cc=vbabka@suse.cz \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox