From: Peng Wang <rocking@whu.edu.cn>
To: cl@linux.com, penberg@kernel.org, rientjes@google.com,
iamjoonsoo.kim@lge.com, akpm@linux-foundation.org
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Peng Wang <rocking@whu.edu.cn>
Subject: [PATCH] mm/slub.c: re-randomize random_seq if necessary
Date: Wed, 9 Jan 2019 17:06:27 +0800 [thread overview]
Message-ID: <20190109090628.1695-1-rocking@whu.edu.cn> (raw)
calculate_sizes() could be called in several places
like (red_zone/poison/order/store_user)_store() while
random_seq remains unchanged.
If random_seq is not NULL in calculate_sizes(), re-randomize it.
Signed-off-by: Peng Wang <rocking@whu.edu.cn>
---
mm/slub.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/mm/slub.c b/mm/slub.c
index 1e3d0ec4e200..2a9d18019545 100644
--- a/mm/slub.c
+++ b/mm/slub.c
@@ -3583,6 +3583,15 @@ static int calculate_sizes(struct kmem_cache *s, int forced_order)
if (oo_objects(s->oo) > oo_objects(s->max))
s->max = s->oo;
+#ifdef CONFIG_SLAB_FREELIST_RANDOM
+ if (unlikely(s->random_seq)) {
+ kfree(s->random_seq);
+ s->random_seq = NULL;
+ if (init_cache_random_seq(s))
+ return 0;
+ }
+#endif
+
return !!oo_objects(s->oo);
}
--
2.19.1
next reply other threads:[~2019-01-09 9:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-09 9:06 Peng Wang [this message]
2019-01-09 12:13 ` Matthew Wilcox
2019-01-09 15:24 ` Peng Wang
2019-01-09 15:24 ` Peng Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190109090628.1695-1-rocking@whu.edu.cn \
--to=rocking@whu.edu.cn \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox