From: YueHaibing <yuehaibing@huawei.com>
To: Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Andrew Morton <akpm@linux-foundation.org>,
Mel Gorman <mgorman@techsingularity.net>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Vlastimil Babka <vbabka@suse.cz>, Michal Hocko <mhocko@suse.com>
Cc: YueHaibing <yuehaibing@huawei.com>, <linux-mm@kvack.org>,
<linux-kernel@vger.kernel.org>, <kernel-janitors@vger.kernel.org>
Subject: [PATCH -next] mm, compaction: remove set but not used variables 'a, b, c'
Date: Wed, 9 Jan 2019 03:02:47 +0000 [thread overview]
Message-ID: <1547002967-6127-1-git-send-email-yuehaibing@huawei.com> (raw)
Message-ID: <20190109030247.S3y4PhG28KGZXVekfK_8DnC-ufxpiyYCREL8htyQamE@z> (raw)
Fixes gcc '-Wunused-but-set-variable' warning:
mm/compaction.c: In function 'compact_zone':
mm/compaction.c:2063:22: warning:
variable 'c' set but not used [-Wunused-but-set-variable]
mm/compaction.c:2063:19: warning:
variable 'b' set but not used [-Wunused-but-set-variable]
mm/compaction.c:2063:16: warning:
variable 'a' set but not used [-Wunused-but-set-variable]
This never used since 94d5992baaa5 ("mm, compaction: finish pageblock
scanning on contention")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
mm/compaction.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/mm/compaction.c b/mm/compaction.c
index f73fe07..529f19a 100644
--- a/mm/compaction.c
+++ b/mm/compaction.c
@@ -2060,7 +2060,6 @@ bool compaction_zonelist_suitable(struct alloc_context *ac, int order,
unsigned long last_migrated_pfn;
const bool sync = cc->mode != MIGRATE_ASYNC;
bool update_cached;
- unsigned long a, b, c;
cc->migratetype = gfpflags_to_migratetype(cc->gfp_mask);
ret = compaction_suitable(cc->zone, cc->order, cc->alloc_flags,
@@ -2106,10 +2105,6 @@ bool compaction_zonelist_suitable(struct alloc_context *ac, int order,
cc->whole_zone = true;
}
- a = cc->migrate_pfn;
- b = cc->free_pfn;
- c = (cc->free_pfn - cc->migrate_pfn) / pageblock_nr_pages;
-
last_migrated_pfn = 0;
/*
next reply other threads:[~2019-01-09 2:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-09 3:02 YueHaibing [this message]
2019-01-09 3:02 ` YueHaibing
2019-01-09 10:15 ` Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1547002967-6127-1-git-send-email-yuehaibing@huawei.com \
--to=yuehaibing@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=mhocko@suse.com \
--cc=sfr@canb.auug.org.au \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox