From: Michal Hocko <mhocko@kernel.org>
To: Alexander Duyck <alexander.h.duyck@linux.intel.com>
Cc: Arun KS <arunks@codeaurora.org>,
arunks.linux@gmail.com, akpm@linux-foundation.org,
vbabka@suse.cz, osalvador@suse.de, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, getarunks@gmail.com
Subject: Re: [PATCH v7] mm/page_alloc.c: memory_hotplug: free pages as higher order
Date: Tue, 8 Jan 2019 19:13:52 +0100 [thread overview]
Message-ID: <20190108181352.GI31793@dhcp22.suse.cz> (raw)
In-Reply-To: <fb6465c99b3ada2c6af587a7eb00016d96d56f77.camel@linux.intel.com>
On Tue 08-01-19 09:56:09, Alexander Duyck wrote:
> On Fri, 2019-01-04 at 10:31 +0530, Arun KS wrote:
[...]
> > static int online_pages_range(unsigned long start_pfn, unsigned long nr_pages,
> > void *arg)
> > {
> > - unsigned long i;
> > unsigned long onlined_pages = *(unsigned long *)arg;
> > - struct page *page;
> >
> > if (PageReserved(pfn_to_page(start_pfn)))
> > - for (i = 0; i < nr_pages; i++) {
> > - page = pfn_to_page(start_pfn + i);
> > - (*online_page_callback)(page);
> > - onlined_pages++;
> > - }
> > + onlined_pages = online_pages_blocks(start_pfn, nr_pages);
>
> Shouldn't this be a "+=" instead of an "="? It seems like you are going
> to lose your count otherwise.
You are right of course. I should have noticed during the review.
Thanks!
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2019-01-08 18:13 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-04 5:01 Arun KS
2019-01-08 17:56 ` Alexander Duyck
2019-01-08 17:56 ` Alexander Duyck
2019-01-08 18:13 ` Michal Hocko [this message]
2019-01-09 5:58 ` Arun KS
2019-01-09 7:37 ` Michal Hocko
2019-01-09 8:28 ` Arun KS
2019-01-09 8:40 ` Michal Hocko
2019-01-09 10:42 ` Arun KS
2019-01-09 10:57 ` Michal Hocko
2019-01-09 11:06 ` Arun KS
2019-01-09 18:56 ` Andrew Morton
2019-01-10 5:06 ` Arun KS
2019-01-08 18:40 ` Alexander Duyck
2019-01-08 18:40 ` Alexander Duyck
2019-01-08 20:04 ` Michal Hocko
2019-01-08 21:53 ` Alexander Duyck
2019-01-08 21:53 ` Alexander Duyck
2019-01-08 22:17 ` Alexander Duyck
2019-01-08 22:17 ` Alexander Duyck
2019-01-09 6:21 ` Arun KS
2019-01-09 16:09 ` Alexander Duyck
2019-01-09 16:09 ` Alexander Duyck
2019-01-10 4:39 ` Arun KS
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190108181352.GI31793@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=alexander.h.duyck@linux.intel.com \
--cc=arunks.linux@gmail.com \
--cc=arunks@codeaurora.org \
--cc=getarunks@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=osalvador@suse.de \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox