From: Catalin Marinas <catalin.marinas@arm.com>
To: Michal Hocko <mhocko@kernel.org>
Cc: Qian Cai <cai@lca.pw>,
akpm@linux-foundation.org, cl@linux.com, penberg@kernel.org,
rientjes@google.com, iamjoonsoo.kim@lge.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] kmemleak: survive in a low-memory situation
Date: Mon, 7 Jan 2019 10:43:14 +0000 [thread overview]
Message-ID: <20190107104314.uugftsqcjsi5j6g2@mbp> (raw)
In-Reply-To: <20190103170735.GV31793@dhcp22.suse.cz>
On Thu, Jan 03, 2019 at 06:07:35PM +0100, Michal Hocko wrote:
> > > On Wed 02-01-19 13:06:19, Qian Cai wrote:
> > > [...]
> > >> diff --git a/mm/kmemleak.c b/mm/kmemleak.c
> > >> index f9d9dc250428..9e1aa3b7df75 100644
> > >> --- a/mm/kmemleak.c
> > >> +++ b/mm/kmemleak.c
> > >> @@ -576,6 +576,16 @@ static struct kmemleak_object *create_object(unsigned long ptr, size_t size,
> > >> struct rb_node **link, *rb_parent;
> > >>
> > >> object = kmem_cache_alloc(object_cache, gfp_kmemleak_mask(gfp));
> > >> +#ifdef CONFIG_PREEMPT_COUNT
> > >> + if (!object) {
> > >> + /* last-ditch effort in a low-memory situation */
> > >> + if (irqs_disabled() || is_idle_task(current) || in_atomic())
> > >> + gfp = GFP_ATOMIC;
> > >> + else
> > >> + gfp = gfp_kmemleak_mask(gfp) | __GFP_DIRECT_RECLAIM;
> > >> + object = kmem_cache_alloc(object_cache, gfp);
> > >> + }
> > >> +#endif
[...]
> I will not object to this workaround but I strongly believe that
> kmemleak should rethink the metadata allocation strategy to be really
> robust.
This would be nice indeed and it was discussed last year. I just haven't
got around to trying anything yet:
https://marc.info/?l=linux-mm&m=152812489819532
--
Catalin
next prev parent reply other threads:[~2019-01-07 10:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-30 5:25 kmemleak not play well with low memory situation Qian Cai
2019-01-02 16:08 ` [PATCH] kmemleak: survive in a low-memory situation Qian Cai
2019-01-02 16:59 ` Catalin Marinas
2019-01-02 18:06 ` [PATCH v2] " Qian Cai
2019-01-03 9:32 ` Michal Hocko
2019-01-03 16:51 ` Qian Cai
2019-01-03 17:07 ` Michal Hocko
2019-01-07 10:43 ` Catalin Marinas [this message]
2019-01-08 2:06 ` Qian Cai
2019-01-08 3:49 ` Qian Cai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190107104314.uugftsqcjsi5j6g2@mbp \
--to=catalin.marinas@arm.com \
--cc=akpm@linux-foundation.org \
--cc=cai@lca.pw \
--cc=cl@linux.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox