Re: [v4 PATCH 1/2] mm: swap: check if swap backing device is congested or not

linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed

From: Daniel Jordan <daniel.m.jordan@oracle.com>
To: Yang Shi <yang.shi@linux.alibaba.com>
Cc: Daniel Jordan <daniel.m.jordan@oracle.com>,
	ying.huang@intel.com, tim.c.chen@intel.com, minchan@kernel.org,
	akpm@linux-foundation.org, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org
Subject: Re: [v4 PATCH 1/2] mm: swap: check if swap backing device is congested or not
Date: Thu, 3 Jan 2019 09:16:02 -0800	[thread overview]
Message-ID: <20190103171602.frjmcagwwqtzwqka@ca-dmjordan1.us.oracle.com> (raw)
In-Reply-To: <76d8727a-77b4-d476-af89-9ae1904ec8cd@linux.alibaba.com>

On Thu, Jan 03, 2019 at 09:10:13AM -0800, Yang Shi wrote:
> How about the below description:
> 
> The test with page_fault1 of will-it-scale (sometimes tracing may just show
> runtest.py that is the wrapper script of page_fault1), which basically
> launches NR_CPU threads to generate 128MB anonymous pages for each thread,ï¿½
> on my virtual machine with congested HDD shows long tail latency is reduced
> significantly.
> 
> Without the patch
> ï¿½page_fault1_thr-1490ï¿½ [023]ï¿½ï¿½ 129.311706: funcgraph_entry: #57377.796 us |ï¿½
> do_swap_page();
> ï¿½page_fault1_thr-1490ï¿½ [023]ï¿½ï¿½ 129.369103: funcgraph_entry: 5.642usï¿½ï¿½ |ï¿½
> do_swap_page();
> ï¿½page_fault1_thr-1490ï¿½ [023]ï¿½ï¿½ 129.369119: funcgraph_entry: #1289.592 us |ï¿½
> do_swap_page();
> ï¿½page_fault1_thr-1490ï¿½ [023]ï¿½ï¿½ 129.370411: funcgraph_entry: 4.957usï¿½ï¿½ |ï¿½
> do_swap_page();
> ï¿½page_fault1_thr-1490ï¿½ [023]ï¿½ï¿½ 129.370419: funcgraph_entry: 1.940usï¿½ï¿½ |ï¿½
> do_swap_page();
> ï¿½page_fault1_thr-1490ï¿½ [023]ï¿½ï¿½ 129.378847: funcgraph_entry: #1411.385 us |ï¿½
> do_swap_page();
> ï¿½page_fault1_thr-1490ï¿½ [023]ï¿½ï¿½ 129.380262: funcgraph_entry: 3.916usï¿½ï¿½ |ï¿½
> do_swap_page();
> ï¿½page_fault1_thr-1490ï¿½ [023]ï¿½ï¿½ 129.380275: funcgraph_entry: #4287.751 us |ï¿½
> do_swap_page();
> 
> With the patch
> ï¿½ï¿½ï¿½ï¿½ï¿½ runtest.py-1417ï¿½ [020]ï¿½ï¿½ 301.925911: funcgraph_entry: #9870.146 us |ï¿½
> do_swap_page();
> ï¿½ï¿½ï¿½ï¿½ï¿½ runtest.py-1417ï¿½ [020]ï¿½ï¿½ 301.935785: funcgraph_entry: 9.802usï¿½ï¿½ |ï¿½
> do_swap_page();
> ï¿½ï¿½ï¿½ï¿½ï¿½ runtest.py-1417ï¿½ [020]ï¿½ï¿½ 301.935799: funcgraph_entry: 3.551usï¿½ï¿½ |ï¿½
> do_swap_page();
> ï¿½ï¿½ï¿½ï¿½ï¿½ runtest.py-1417ï¿½ [020]ï¿½ï¿½ 301.935806: funcgraph_entry: 2.142usï¿½ï¿½ |ï¿½
> do_swap_page();
> ï¿½ï¿½ï¿½ï¿½ï¿½ runtest.py-1417ï¿½ [020]ï¿½ï¿½ 301.935853: funcgraph_entry: 6.938usï¿½ï¿½ |ï¿½
> do_swap_page();
> ï¿½ï¿½ï¿½ï¿½ï¿½ runtest.py-1417ï¿½ [020]ï¿½ï¿½ 301.935864: funcgraph_entry: 3.765usï¿½ï¿½ |ï¿½
> do_swap_page();
> ï¿½ï¿½ï¿½ï¿½ï¿½ runtest.py-1417ï¿½ [020]ï¿½ï¿½ 301.935871: funcgraph_entry: 3.600usï¿½ï¿½ |ï¿½
> do_swap_page();
> ï¿½ï¿½ï¿½ï¿½ï¿½ runtest.py-1417ï¿½ [020]ï¿½ï¿½ 301.935878: funcgraph_entry: 7.202usï¿½ï¿½ |ï¿½
> do_swap_page();

That's better, thanks!

WARNING: multiple messages have this Message-ID

From: Daniel Jordan <daniel.m.jordan@oracle.com>
To: Yang Shi <yang.shi@linux.alibaba.com>
Cc: Daniel Jordan <daniel.m.jordan@oracle.com>,
	ying.huang@intel.com, tim.c.chen@intel.com, minchan@kernel.org,
	akpm@linux-foundation.org, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org
Subject: Re: [v4 PATCH 1/2] mm: swap: check if swap backing device is congested or not
Date: Thu, 3 Jan 2019 09:16:02 -0800	[thread overview]
Message-ID: <20190103171602.frjmcagwwqtzwqka@ca-dmjordan1.us.oracle.com> (raw)
Message-ID: <20190103171602.IYzfRq5uIanY3V-FjVLGnXvsl6q1b-bROHrMn0UKMJ0@z> (raw)
In-Reply-To: <76d8727a-77b4-d476-af89-9ae1904ec8cd@linux.alibaba.com>

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="UTF-8", Size: 1992 bytes --]

On Thu, Jan 03, 2019 at 09:10:13AM -0800, Yang Shi wrote:
> How about the below description:
> 
> The test with page_fault1 of will-it-scale (sometimes tracing may just show
> runtest.py that is the wrapper script of page_fault1), which basically
> launches NR_CPU threads to generate 128MB anonymous pages for each thread, 
> on my virtual machine with congested HDD shows long tail latency is reduced
> significantly.
> 
> Without the patch
>  page_fault1_thr-1490  [023]   129.311706: funcgraph_entry: #57377.796 us | 
> do_swap_page();
>  page_fault1_thr-1490  [023]   129.369103: funcgraph_entry: 5.642us   | 
> do_swap_page();
>  page_fault1_thr-1490  [023]   129.369119: funcgraph_entry: #1289.592 us | 
> do_swap_page();
>  page_fault1_thr-1490  [023]   129.370411: funcgraph_entry: 4.957us   | 
> do_swap_page();
>  page_fault1_thr-1490  [023]   129.370419: funcgraph_entry: 1.940us   | 
> do_swap_page();
>  page_fault1_thr-1490  [023]   129.378847: funcgraph_entry: #1411.385 us | 
> do_swap_page();
>  page_fault1_thr-1490  [023]   129.380262: funcgraph_entry: 3.916us   | 
> do_swap_page();
>  page_fault1_thr-1490  [023]   129.380275: funcgraph_entry: #4287.751 us | 
> do_swap_page();
> 
> With the patch
>       runtest.py-1417  [020]   301.925911: funcgraph_entry: #9870.146 us | 
> do_swap_page();
>       runtest.py-1417  [020]   301.935785: funcgraph_entry: 9.802us   | 
> do_swap_page();
>       runtest.py-1417  [020]   301.935799: funcgraph_entry: 3.551us   | 
> do_swap_page();
>       runtest.py-1417  [020]   301.935806: funcgraph_entry: 2.142us   | 
> do_swap_page();
>       runtest.py-1417  [020]   301.935853: funcgraph_entry: 6.938us   | 
> do_swap_page();
>       runtest.py-1417  [020]   301.935864: funcgraph_entry: 3.765us   | 
> do_swap_page();
>       runtest.py-1417  [020]   301.935871: funcgraph_entry: 3.600us   | 
> do_swap_page();
>       runtest.py-1417  [020]   301.935878: funcgraph_entry: 7.202us   | 
> do_swap_page();

That's better, thanks!

next prev parent reply	other threads:[~2019-01-03 17:15 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-30  4:49 Yang Shi
2018-12-30  4:49 ` [v4 PATCH 2/2] mm: swap: add comment for swap_vma_readahead Yang Shi
2019-01-03  7:41   ` Huang, Ying
2019-01-03  7:41     ` Huang, Ying
2019-01-03 17:12     ` Yang Shi
2019-01-02 23:00 ` [v4 PATCH 1/2] mm: swap: check if swap backing device is congested or not Daniel Jordan
2019-01-03 17:10   ` Yang Shi
2019-01-03 17:16     ` Daniel Jordan [this message]
2019-01-03 17:16       ` Daniel Jordan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190103171602.frjmcagwwqtzwqka@ca-dmjordan1.us.oracle.com \
    --to=daniel.m.jordan@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=minchan@kernel.org \
    --cc=tim.c.chen@intel.com \
    --cc=yang.shi@linux.alibaba.com \
    --cc=ying.huang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox