From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) by kanga.kvack.org (Postfix) with ESMTP id E82A58E0002 for ; Wed, 2 Jan 2019 07:24:53 -0500 (EST) Received: by mail-ed1-f70.google.com with SMTP id t7so31689763edr.21 for ; Wed, 02 Jan 2019 04:24:53 -0800 (PST) Received: from outbound-smtp25.blacknight.com (outbound-smtp25.blacknight.com. [81.17.249.193]) by mx.google.com with ESMTPS id a7si513504edl.383.2019.01.02.04.24.52 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 02 Jan 2019 04:24:52 -0800 (PST) Received: from mail.blacknight.com (pemlinmail01.blacknight.ie [81.17.254.10]) by outbound-smtp25.blacknight.com (Postfix) with ESMTPS id 66B90B89DA for ; Wed, 2 Jan 2019 12:24:52 +0000 (GMT) Date: Wed, 2 Jan 2019 12:24:50 +0000 From: Mel Gorman Subject: Re: [PATCH] mm: compaction.c: Propagate return value upstream Message-ID: <20190102122450.GD31517@techsingularity.net> References: <20181226194257.11038-1-pakki001@umn.edu> <20181227035029.GE20878@bombadil.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20181227035029.GE20878@bombadil.infradead.org> Sender: owner-linux-mm@kvack.org List-ID: To: Matthew Wilcox Cc: Aditya Pakki , kjlu@umn.edu, Andrew Morton , Michal Hocko , Vlastimil Babka , Joonsoo Kim , David Rientjes , Yang Shi , Johannes Weiner , Joe Perches , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Randy Dunlap On Wed, Dec 26, 2018 at 07:50:29PM -0800, Matthew Wilcox wrote: > On Wed, Dec 26, 2018 at 01:42:56PM -0600, Aditya Pakki wrote: > > In sysctl_extfrag_handler(), proc_dointvec_minmax() can return an > > error. The fix propagates the error upstream in case of failure. > > Why not just ... > > Mel, Randy? You seem to have been the prime instigators on this. > Patch seems fine. Acked-by: Mel Gorman -- Mel Gorman SUSE Labs