* [PATCH] hmm: Warn on devres_release failure
@ 2018-12-26 18:09 Aditya Pakki
2018-12-26 22:22 ` Jerome Glisse
0 siblings, 1 reply; 3+ messages in thread
From: Aditya Pakki @ 2018-12-26 18:09 UTC (permalink / raw)
To: pakki001; +Cc: kjlu, Jérôme Glisse, linux-mm, linux-kernel
devres_release can return -ENOENT if the device is not freed. The fix
throws a warning consistent with other invocations.
Signed-off-by: Aditya Pakki <pakki001@umn.edu>
---
mm/hmm.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/mm/hmm.c b/mm/hmm.c
index 90c34f3d1243..b06e3f092fbf 100644
--- a/mm/hmm.c
+++ b/mm/hmm.c
@@ -1183,8 +1183,12 @@ static int hmm_devmem_match(struct device *dev, void *data, void *match_data)
static void hmm_devmem_pages_remove(struct hmm_devmem *devmem)
{
- devres_release(devmem->device, &hmm_devmem_release,
- &hmm_devmem_match, devmem->resource);
+ int rc;
+
+ rc = devres_release(devmem->device, &hmm_devmem_release,
+ &hmm_devmem_match, devmem->resource);
+ if (rc)
+ WARN_ON(rc);
}
/*
--
2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] hmm: Warn on devres_release failure
2018-12-26 18:09 [PATCH] hmm: Warn on devres_release failure Aditya Pakki
@ 2018-12-26 22:22 ` Jerome Glisse
2018-12-26 22:22 ` Jerome Glisse
0 siblings, 1 reply; 3+ messages in thread
From: Jerome Glisse @ 2018-12-26 22:22 UTC (permalink / raw)
To: Aditya Pakki; +Cc: kjlu, linux-mm, linux-kernel
On Wed, Dec 26, 2018 at 12:09:04PM -0600, Aditya Pakki wrote:
> devres_release can return -ENOENT if the device is not freed. The fix
> throws a warning consistent with other invocations.
>
> Signed-off-by: Aditya Pakki <pakki001@umn.edu>
Reviewed-by: J�r�me Glisse <jglisse@redhat.com>
> ---
> mm/hmm.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/mm/hmm.c b/mm/hmm.c
> index 90c34f3d1243..b06e3f092fbf 100644
> --- a/mm/hmm.c
> +++ b/mm/hmm.c
> @@ -1183,8 +1183,12 @@ static int hmm_devmem_match(struct device *dev, void *data, void *match_data)
>
> static void hmm_devmem_pages_remove(struct hmm_devmem *devmem)
> {
> - devres_release(devmem->device, &hmm_devmem_release,
> - &hmm_devmem_match, devmem->resource);
> + int rc;
> +
> + rc = devres_release(devmem->device, &hmm_devmem_release,
> + &hmm_devmem_match, devmem->resource);
> + if (rc)
> + WARN_ON(rc);
> }
>
> /*
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] hmm: Warn on devres_release failure
2018-12-26 22:22 ` Jerome Glisse
@ 2018-12-26 22:22 ` Jerome Glisse
0 siblings, 0 replies; 3+ messages in thread
From: Jerome Glisse @ 2018-12-26 22:22 UTC (permalink / raw)
To: Aditya Pakki; +Cc: kjlu, linux-mm, linux-kernel
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="UTF-8", Size: 956 bytes --]
On Wed, Dec 26, 2018 at 12:09:04PM -0600, Aditya Pakki wrote:
> devres_release can return -ENOENT if the device is not freed. The fix
> throws a warning consistent with other invocations.
>
> Signed-off-by: Aditya Pakki <pakki001@umn.edu>
Reviewed-by: Jérôme Glisse <jglisse@redhat.com>
> ---
> mm/hmm.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/mm/hmm.c b/mm/hmm.c
> index 90c34f3d1243..b06e3f092fbf 100644
> --- a/mm/hmm.c
> +++ b/mm/hmm.c
> @@ -1183,8 +1183,12 @@ static int hmm_devmem_match(struct device *dev, void *data, void *match_data)
>
> static void hmm_devmem_pages_remove(struct hmm_devmem *devmem)
> {
> - devres_release(devmem->device, &hmm_devmem_release,
> - &hmm_devmem_match, devmem->resource);
> + int rc;
> +
> + rc = devres_release(devmem->device, &hmm_devmem_release,
> + &hmm_devmem_match, devmem->resource);
> + if (rc)
> + WARN_ON(rc);
> }
>
> /*
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-12-26 22:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-26 18:09 [PATCH] hmm: Warn on devres_release failure Aditya Pakki
2018-12-26 22:22 ` Jerome Glisse
2018-12-26 22:22 ` Jerome Glisse
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox