From: Fengguang Wu <fengguang.wu@intel.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Linux Memory Management List <linux-mm@kvack.org>,
Fengguang Wu <fengguang.wu@intel.com>,
kvm@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Fan Du <fan.du@intel.com>, Yao Yuan <yuan.yao@intel.com>,
Peng Dong <dongx.peng@intel.com>,
Huang Ying <ying.huang@intel.com>,
Liu Jingqi <jingqi.liu@intel.com>,
Dong Eddie <eddie.dong@intel.com>,
Dave Hansen <dave.hansen@intel.com>,
Zhang Yi <yi.z.zhang@linux.intel.com>,
Dan Williams <dan.j.williams@intel.com>
Subject: [RFC][PATCH v2 09/21] mm: avoid duplicate peer target node
Date: Wed, 26 Dec 2018 21:14:55 +0800 [thread overview]
Message-ID: <20181226133351.579378360@intel.com> (raw)
In-Reply-To: <20181226131446.330864849@intel.com>
[-- Attachment #1: 0020-page_alloc-avoid-duplicate-peer-target-node.patch --]
[-- Type: text/plain, Size: 2143 bytes --]
To ensure 1:1 peer node mapping on broken BIOS
node distances:
node 0 1 2 3
0: 10 21 20 20
1: 21 10 20 20
2: 20 20 10 20
3: 20 20 20 10
or with numa=fake=4U
node distances:
node 0 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15
0: 10 10 10 10 21 21 21 21 17 17 17 17 28 28 28 28
1: 10 10 10 10 21 21 21 21 17 17 17 17 28 28 28 28
2: 10 10 10 10 21 21 21 21 17 17 17 17 28 28 28 28
3: 10 10 10 10 21 21 21 21 17 17 17 17 28 28 28 28
4: 21 21 21 21 10 10 10 10 28 28 28 28 17 17 17 17
5: 21 21 21 21 10 10 10 10 28 28 28 28 17 17 17 17
6: 21 21 21 21 10 10 10 10 28 28 28 28 17 17 17 17
7: 21 21 21 21 10 10 10 10 28 28 28 28 17 17 17 17
8: 17 17 17 17 28 28 28 28 10 10 10 10 28 28 28 28
9: 17 17 17 17 28 28 28 28 10 10 10 10 28 28 28 28
10: 17 17 17 17 28 28 28 28 10 10 10 10 28 28 28 28
11: 17 17 17 17 28 28 28 28 10 10 10 10 28 28 28 28
12: 28 28 28 28 17 17 17 17 28 28 28 28 10 10 10 10
13: 28 28 28 28 17 17 17 17 28 28 28 28 10 10 10 10
14: 28 28 28 28 17 17 17 17 28 28 28 28 10 10 10 10
15: 28 28 28 28 17 17 17 17 28 28 28 28 10 10 10 10
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
mm/page_alloc.c | 6 ++++++
1 file changed, 6 insertions(+)
--- linux.orig/mm/page_alloc.c 2018-12-23 19:48:27.366110325 +0800
+++ linux/mm/page_alloc.c 2018-12-23 19:48:27.362110332 +0800
@@ -6941,16 +6941,22 @@ static int find_best_peer_node(int nid)
int n, val;
int min_val = INT_MAX;
int peer = NUMA_NO_NODE;
+ static nodemask_t target_nodes = NODE_MASK_NONE;
for_each_online_node(n) {
if (n == nid)
continue;
val = node_distance(nid, n);
+ if (val == LOCAL_DISTANCE)
+ continue;
+ if (node_isset(n, target_nodes))
+ continue;
if (val < min_val) {
min_val = val;
peer = n;
}
}
+ node_set(peer, target_nodes);
return peer;
}
WARNING: multiple messages have this Message-ID
From: Fengguang Wu <fengguang.wu@intel.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Linux Memory Management List <linux-mm@kvack.org>,
Fengguang Wu <fengguang.wu@intel.com>
Cc: kvm@vger.kernel.org
Cc: LKML <linux-kernel@vger.kernel.org>
Cc: Fan Du <fan.du@intel.com>
Cc: Yao Yuan <yuan.yao@intel.com>
Cc: Peng Dong <dongx.peng@intel.com>
Cc: Huang Ying <ying.huang@intel.com>
Cc: Liu Jingqi <jingqi.liu@intel.com>
Cc: Dong Eddie <eddie.dong@intel.com>
Cc: Dave Hansen <dave.hansen@intel.com>
Cc: Zhang Yi <yi.z.zhang@linux.intel.com>
Cc: Dan Williams <dan.j.williams@intel.com>
Subject: [RFC][PATCH v2 09/21] mm: avoid duplicate peer target node
Date: Wed, 26 Dec 2018 21:14:55 +0800 [thread overview]
Message-ID: <20181226133351.579378360@intel.com> (raw)
Message-ID: <20181226131455.VI0asQHzUvk6J-NUVMZETk3SZRcavk0DKH8_tRurpKs@z> (raw)
In-Reply-To: <20181226131446.330864849@intel.com>
[-- Attachment #1: 0020-page_alloc-avoid-duplicate-peer-target-node.patch --]
[-- Type: text/plain, Size: 2145 bytes --]
To ensure 1:1 peer node mapping on broken BIOS
node distances:
node 0 1 2 3
0: 10 21 20 20
1: 21 10 20 20
2: 20 20 10 20
3: 20 20 20 10
or with numa=fake=4U
node distances:
node 0 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15
0: 10 10 10 10 21 21 21 21 17 17 17 17 28 28 28 28
1: 10 10 10 10 21 21 21 21 17 17 17 17 28 28 28 28
2: 10 10 10 10 21 21 21 21 17 17 17 17 28 28 28 28
3: 10 10 10 10 21 21 21 21 17 17 17 17 28 28 28 28
4: 21 21 21 21 10 10 10 10 28 28 28 28 17 17 17 17
5: 21 21 21 21 10 10 10 10 28 28 28 28 17 17 17 17
6: 21 21 21 21 10 10 10 10 28 28 28 28 17 17 17 17
7: 21 21 21 21 10 10 10 10 28 28 28 28 17 17 17 17
8: 17 17 17 17 28 28 28 28 10 10 10 10 28 28 28 28
9: 17 17 17 17 28 28 28 28 10 10 10 10 28 28 28 28
10: 17 17 17 17 28 28 28 28 10 10 10 10 28 28 28 28
11: 17 17 17 17 28 28 28 28 10 10 10 10 28 28 28 28
12: 28 28 28 28 17 17 17 17 28 28 28 28 10 10 10 10
13: 28 28 28 28 17 17 17 17 28 28 28 28 10 10 10 10
14: 28 28 28 28 17 17 17 17 28 28 28 28 10 10 10 10
15: 28 28 28 28 17 17 17 17 28 28 28 28 10 10 10 10
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
mm/page_alloc.c | 6 ++++++
1 file changed, 6 insertions(+)
--- linux.orig/mm/page_alloc.c 2018-12-23 19:48:27.366110325 +0800
+++ linux/mm/page_alloc.c 2018-12-23 19:48:27.362110332 +0800
@@ -6941,16 +6941,22 @@ static int find_best_peer_node(int nid)
int n, val;
int min_val = INT_MAX;
int peer = NUMA_NO_NODE;
+ static nodemask_t target_nodes = NODE_MASK_NONE;
for_each_online_node(n) {
if (n == nid)
continue;
val = node_distance(nid, n);
+ if (val == LOCAL_DISTANCE)
+ continue;
+ if (node_isset(n, target_nodes))
+ continue;
if (val < min_val) {
min_val = val;
peer = n;
}
}
+ node_set(peer, target_nodes);
return peer;
}
next prev parent reply other threads:[~2018-12-26 13:37 UTC|newest]
Thread overview: 99+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-26 13:14 [RFC][PATCH v2 00/21] PMEM NUMA node and hotness accounting/migration Fengguang Wu
2018-12-26 13:14 ` Fengguang Wu
2018-12-26 13:14 ` [RFC][PATCH v2 01/21] e820: cheat PMEM as DRAM Fengguang Wu
2018-12-26 13:14 ` Fengguang Wu
2018-12-27 3:41 ` Matthew Wilcox
2018-12-27 4:11 ` Fengguang Wu
2018-12-27 5:13 ` Dan Williams
2018-12-27 5:13 ` Dan Williams
2018-12-27 19:32 ` Yang Shi
2018-12-27 19:32 ` Yang Shi
2018-12-28 3:27 ` Fengguang Wu
2018-12-26 13:14 ` [RFC][PATCH v2 02/21] acpi/numa: memorize NUMA node type from SRAT table Fengguang Wu
2018-12-26 13:14 ` Fengguang Wu
2018-12-26 13:14 ` [RFC][PATCH v2 03/21] x86/numa_emulation: fix fake NUMA in uniform case Fengguang Wu
2018-12-26 13:14 ` Fengguang Wu
2018-12-26 13:14 ` [RFC][PATCH v2 04/21] x86/numa_emulation: pass numa node type to fake nodes Fengguang Wu
2018-12-26 13:14 ` Fengguang Wu
2018-12-26 13:14 ` [RFC][PATCH v2 05/21] mmzone: new pgdat flags for DRAM and PMEM Fengguang Wu
2018-12-26 13:14 ` Fengguang Wu
2018-12-26 13:14 ` [RFC][PATCH v2 06/21] x86,numa: update numa node type Fengguang Wu
2018-12-26 13:14 ` Fengguang Wu
2018-12-26 13:14 ` [RFC][PATCH v2 07/21] mm: export node type {pmem|dram} under /sys/bus/node Fengguang Wu
2018-12-26 13:14 ` Fengguang Wu
2018-12-26 13:14 ` [RFC][PATCH v2 08/21] mm: introduce and export pgdat peer_node Fengguang Wu
2018-12-26 13:14 ` Fengguang Wu
2018-12-27 20:07 ` Christopher Lameter
2018-12-27 20:07 ` Christopher Lameter
2018-12-28 2:31 ` Fengguang Wu
2018-12-26 13:14 ` Fengguang Wu [this message]
2018-12-26 13:14 ` [RFC][PATCH v2 09/21] mm: avoid duplicate peer target node Fengguang Wu
2018-12-26 13:14 ` [RFC][PATCH v2 10/21] mm: build separate zonelist for PMEM and DRAM node Fengguang Wu
2018-12-26 13:14 ` Fengguang Wu
2019-01-01 9:14 ` Aneesh Kumar K.V
2019-01-01 9:14 ` Aneesh Kumar K.V
2019-01-07 9:57 ` Fengguang Wu
2019-01-07 14:09 ` Aneesh Kumar K.V
2018-12-26 13:14 ` [RFC][PATCH v2 11/21] kvm: allocate page table pages from DRAM Fengguang Wu
2018-12-26 13:14 ` Fengguang Wu
2019-01-01 9:23 ` Aneesh Kumar K.V
2019-01-01 9:23 ` Aneesh Kumar K.V
2019-01-02 0:59 ` Yuan Yao
2019-01-02 16:47 ` Dave Hansen
2019-01-07 10:21 ` Fengguang Wu
2018-12-26 13:14 ` [RFC][PATCH v2 12/21] x86/pgtable: " Fengguang Wu
2018-12-26 13:14 ` Fengguang Wu
2018-12-26 13:14 ` [RFC][PATCH v2 13/21] x86/pgtable: dont check PMD accessed bit Fengguang Wu
2018-12-26 13:14 ` Fengguang Wu
2018-12-26 13:15 ` [RFC][PATCH v2 14/21] kvm: register in mm_struct Fengguang Wu
2018-12-26 13:15 ` Fengguang Wu
2019-02-02 6:57 ` Peter Xu
2019-02-02 10:50 ` Fengguang Wu
2019-02-04 10:46 ` Paolo Bonzini
2018-12-26 13:15 ` [RFC][PATCH v2 15/21] ept-idle: EPT walk for virtual machine Fengguang Wu
2018-12-26 13:15 ` Fengguang Wu
2018-12-26 13:15 ` [RFC][PATCH v2 16/21] mm-idle: mm_walk for normal task Fengguang Wu
2018-12-26 13:15 ` Fengguang Wu
2018-12-26 13:15 ` [RFC][PATCH v2 17/21] proc: introduce /proc/PID/idle_pages Fengguang Wu
2018-12-26 13:15 ` Fengguang Wu
2018-12-26 13:15 ` [RFC][PATCH v2 18/21] kvm-ept-idle: enable module Fengguang Wu
2018-12-26 13:15 ` Fengguang Wu
2018-12-26 13:15 ` [RFC][PATCH v2 19/21] mm/migrate.c: add move_pages(MPOL_MF_SW_YOUNG) flag Fengguang Wu
2018-12-26 13:15 ` Fengguang Wu
2018-12-26 13:15 ` [RFC][PATCH v2 20/21] mm/vmscan.c: migrate anon DRAM pages to PMEM node Fengguang Wu
2018-12-26 13:15 ` Fengguang Wu
2018-12-26 13:15 ` [RFC][PATCH v2 21/21] mm/vmscan.c: shrink anon list if can migrate to PMEM Fengguang Wu
2018-12-26 13:15 ` Fengguang Wu
2018-12-27 20:31 ` [RFC][PATCH v2 00/21] PMEM NUMA node and hotness accounting/migration Michal Hocko
2018-12-28 5:08 ` Fengguang Wu
2018-12-28 8:41 ` Michal Hocko
2018-12-28 9:42 ` Fengguang Wu
2018-12-28 12:15 ` Michal Hocko
2018-12-28 13:15 ` Fengguang Wu
2018-12-28 13:15 ` Fengguang Wu
2018-12-28 19:46 ` Michal Hocko
2018-12-28 13:31 ` Fengguang Wu
2018-12-28 18:28 ` Yang Shi
2018-12-28 18:28 ` Yang Shi
2018-12-28 19:52 ` Michal Hocko
2019-01-02 12:21 ` Jonathan Cameron
2019-01-02 12:21 ` Jonathan Cameron
2019-01-08 14:52 ` Michal Hocko
2019-01-10 15:53 ` Jerome Glisse
2019-01-10 15:53 ` Jerome Glisse
2019-01-10 16:42 ` Michal Hocko
2019-01-10 17:42 ` Jerome Glisse
2019-01-10 17:42 ` Jerome Glisse
2019-01-10 18:26 ` Jonathan Cameron
2019-01-10 18:26 ` Jonathan Cameron
2019-01-28 17:42 ` Jonathan Cameron
2019-01-28 17:42 ` Jonathan Cameron
2019-01-29 2:00 ` Fengguang Wu
2019-01-03 10:57 ` Mel Gorman
2019-01-10 16:25 ` Jerome Glisse
2019-01-10 16:25 ` Jerome Glisse
2019-01-10 16:50 ` Michal Hocko
2019-01-10 18:02 ` Jerome Glisse
2019-01-10 18:02 ` Jerome Glisse
2019-01-02 18:12 ` Dave Hansen
2019-01-08 14:53 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181226133351.579378360@intel.com \
--to=fengguang.wu@intel.com \
--cc=akpm@linux-foundation.org \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@intel.com \
--cc=dongx.peng@intel.com \
--cc=eddie.dong@intel.com \
--cc=fan.du@intel.com \
--cc=jingqi.liu@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=yi.z.zhang@linux.intel.com \
--cc=ying.huang@intel.com \
--cc=yuan.yao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox