* [PATCH -mmotm] arm64: skip kmemleak for KASAN again
@ 2018-12-26 2:05 Qian Cai
2018-12-27 15:21 ` Andrey Konovalov
0 siblings, 1 reply; 3+ messages in thread
From: Qian Cai @ 2018-12-26 2:05 UTC (permalink / raw)
To: akpm
Cc: catalin.marinas, will.deacon, andreyknvl, dvyukov, linux-mm,
linux-arm-kernel, linux-kernel, Qian Cai
Due to 871ac3d540f (kasan: initialize shadow to 0xff for tag-based
mode), kmemleak is broken again with KASAN. It needs a similar fix
from e55058c2983 (mm/memblock.c: skip kmemleak for kasan_init()).
Signed-off-by: Qian Cai <cai@lca.pw>
---
arch/arm64/mm/kasan_init.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/arch/arm64/mm/kasan_init.c b/arch/arm64/mm/kasan_init.c
index 48d8f2fa0d14..4b55b15707a3 100644
--- a/arch/arm64/mm/kasan_init.c
+++ b/arch/arm64/mm/kasan_init.c
@@ -47,8 +47,7 @@ static phys_addr_t __init kasan_alloc_raw_page(int node)
{
void *p = memblock_alloc_try_nid_raw(PAGE_SIZE, PAGE_SIZE,
__pa(MAX_DMA_ADDRESS),
- MEMBLOCK_ALLOC_ACCESSIBLE,
- node);
+ MEMBLOCK_ALLOC_KASAN, node);
return __pa(p);
}
--
2.17.2 (Apple Git-113)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -mmotm] arm64: skip kmemleak for KASAN again
2018-12-26 2:05 [PATCH -mmotm] arm64: skip kmemleak for KASAN again Qian Cai
@ 2018-12-27 15:21 ` Andrey Konovalov
2018-12-27 15:21 ` Andrey Konovalov
0 siblings, 1 reply; 3+ messages in thread
From: Andrey Konovalov @ 2018-12-27 15:21 UTC (permalink / raw)
To: Qian Cai
Cc: Andrew Morton, Catalin Marinas, Will Deacon, Dmitry Vyukov,
Linux Memory Management List, Linux ARM, LKML
On Wed, Dec 26, 2018 at 3:06 AM Qian Cai <cai@lca.pw> wrote:
>
> Due to 871ac3d540f (kasan: initialize shadow to 0xff for tag-based
> mode), kmemleak is broken again with KASAN. It needs a similar fix
> from e55058c2983 (mm/memblock.c: skip kmemleak for kasan_init()).
>
> Signed-off-by: Qian Cai <cai@lca.pw>
Hi Qian,
Sorry, didn't see your first kmemleak fix. I can merge this fix into
my series if I end up resending it.
In any case:
Acked-by: Andrey Konovalov <andreyknvl@google.com>
Thanks!
> ---
> arch/arm64/mm/kasan_init.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/arm64/mm/kasan_init.c b/arch/arm64/mm/kasan_init.c
> index 48d8f2fa0d14..4b55b15707a3 100644
> --- a/arch/arm64/mm/kasan_init.c
> +++ b/arch/arm64/mm/kasan_init.c
> @@ -47,8 +47,7 @@ static phys_addr_t __init kasan_alloc_raw_page(int node)
> {
> void *p = memblock_alloc_try_nid_raw(PAGE_SIZE, PAGE_SIZE,
> __pa(MAX_DMA_ADDRESS),
> - MEMBLOCK_ALLOC_ACCESSIBLE,
> - node);
> + MEMBLOCK_ALLOC_KASAN, node);
> return __pa(p);
> }
>
> --
> 2.17.2 (Apple Git-113)
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -mmotm] arm64: skip kmemleak for KASAN again
2018-12-27 15:21 ` Andrey Konovalov
@ 2018-12-27 15:21 ` Andrey Konovalov
0 siblings, 0 replies; 3+ messages in thread
From: Andrey Konovalov @ 2018-12-27 15:21 UTC (permalink / raw)
To: Qian Cai
Cc: Andrew Morton, Catalin Marinas, Will Deacon, Dmitry Vyukov,
Linux Memory Management List, Linux ARM, LKML
On Wed, Dec 26, 2018 at 3:06 AM Qian Cai <cai@lca.pw> wrote:
>
> Due to 871ac3d540f (kasan: initialize shadow to 0xff for tag-based
> mode), kmemleak is broken again with KASAN. It needs a similar fix
> from e55058c2983 (mm/memblock.c: skip kmemleak for kasan_init()).
>
> Signed-off-by: Qian Cai <cai@lca.pw>
Hi Qian,
Sorry, didn't see your first kmemleak fix. I can merge this fix into
my series if I end up resending it.
In any case:
Acked-by: Andrey Konovalov <andreyknvl@google.com>
Thanks!
> ---
> arch/arm64/mm/kasan_init.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/arm64/mm/kasan_init.c b/arch/arm64/mm/kasan_init.c
> index 48d8f2fa0d14..4b55b15707a3 100644
> --- a/arch/arm64/mm/kasan_init.c
> +++ b/arch/arm64/mm/kasan_init.c
> @@ -47,8 +47,7 @@ static phys_addr_t __init kasan_alloc_raw_page(int node)
> {
> void *p = memblock_alloc_try_nid_raw(PAGE_SIZE, PAGE_SIZE,
> __pa(MAX_DMA_ADDRESS),
> - MEMBLOCK_ALLOC_ACCESSIBLE,
> - node);
> + MEMBLOCK_ALLOC_KASAN, node);
> return __pa(p);
> }
>
> --
> 2.17.2 (Apple Git-113)
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-12-27 15:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-26 2:05 [PATCH -mmotm] arm64: skip kmemleak for KASAN again Qian Cai
2018-12-27 15:21 ` Andrey Konovalov
2018-12-27 15:21 ` Andrey Konovalov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox