Re: [PATCH 6/6] psi: introduce psi monitor

[kbuild test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2058 bytes --]

Hi Suren,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v4.20-rc7]
[cannot apply to next-20181221]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Suren-Baghdasaryan/psi-pressure-stall-monitors/20181215-181714
config: i386-randconfig-i2-12162314 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All errors (new ones prefixed by >>):

   kernel/sched/psi.o: In function `psi_trigger_create':
>> kernel/sched/psi.c:1029: undefined reference to `__udivdi3'
   kernel/sched/psi.o: In function `psi_trigger_destroy':
   kernel/sched/psi.c:1057: undefined reference to `__udivdi3'

vim +1029 kernel/sched/psi.c

  1006	
  1007	struct psi_trigger *psi_trigger_create(struct psi_group *group,
  1008			enum psi_states state, u32 threshold_us, u32 win_sz_us)
  1009	{
  1010		struct psi_trigger *t;
  1011	
  1012		if (static_branch_likely(&psi_disabled))
  1013			return ERR_PTR(-EOPNOTSUPP);
  1014	
  1015		t = kzalloc(sizeof(*t), GFP_KERNEL);
  1016		if (!t)
  1017			return ERR_PTR(-ENOMEM);
  1018	
  1019		t->group = group;
  1020		t->state = state;
  1021		t->threshold = threshold_us * NSEC_PER_USEC;
  1022		t->win.size = win_sz_us * NSEC_PER_USEC;
  1023		t->event = 0;
  1024		init_waitqueue_head(&t->event_wait);
  1025	
  1026		mutex_lock(&group->update_lock);
  1027	
  1028		list_add(&t->node, &group->triggers);
> 1029		group->trigger_min_period = min(group->trigger_min_period,
  1030			t->win.size / PSI_TRIG_UPDATES_PER_WIN);
  1031		group->nr_triggers[t->state]++;
  1032		group->trigger_mask |= (1 << t->state);
  1033	
  1034		mutex_unlock(&group->update_lock);
  1035	
  1036		return t;
  1037	}
  1038	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 32613 bytes --]