From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Mike Kravetz <mike.kravetz@oracle.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Michal Hocko <mhocko@kernel.org>, Hugh Dickins <hughd@google.com>,
Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
"Aneesh Kumar K . V" <aneesh.kumar@linux.vnet.ibm.com>,
Andrea Arcangeli <aarcange@redhat.com>,
"Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
Davidlohr Bueso <dave@stgolabs.net>,
Prakash Sangappa <prakash.sangappa@oracle.com>,
Andrew Morton <akpm@linux-foundation.org>,
stable@vger.kernel.org
Subject: Re: [PATCH v2 2/2] hugetlbfs: Use i_mmap_rwsem to fix page fault/truncate race
Date: Sun, 23 Dec 2018 01:14:12 +0300 [thread overview]
Message-ID: <20181222221411.ktm5qeebi43lvce5@kshutemo-mobl1> (raw)
In-Reply-To: <732c0b7d-5a4e-97a8-9677-30f3520893cb@oracle.com>
On Fri, Dec 21, 2018 at 02:17:32PM -0800, Mike Kravetz wrote:
> Am I misunderstanding your question/concern?
No. Thanks for the clarification.
>
> I have decided to add the locking (although unnecessary) with something like
> this in hugetlbfs_evict_inode.
>
> /*
> * The vfs layer guarantees that there are no other users of this
> * inode. Therefore, it would be safe to call remove_inode_hugepages
> * without holding i_mmap_rwsem. We acquire and hold here to be
> * consistent with other callers. Since there will be no contention
> * on the semaphore, overhead is negligible.
> */
> i_mmap_lock_write(mapping);
> remove_inode_hugepages(inode, 0, LLONG_MAX);
> i_mmap_unlock_write(mapping);
LGTM.
--
Kirill A. Shutemov
next prev parent reply other threads:[~2018-12-22 22:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-18 22:35 [PATCH v2 0/2] hugetlbfs: use i_mmap_rwsem for better synchronization Mike Kravetz
2018-12-18 22:35 ` [PATCH v2 1/2] hugetlbfs: use i_mmap_rwsem for more pmd sharing synchronization Mike Kravetz
2018-12-19 1:24 ` Sasha Levin
2018-12-21 10:05 ` Kirill A. Shutemov
2018-12-21 18:20 ` Mike Kravetz
2018-12-18 22:35 ` [PATCH v2 2/2] hugetlbfs: Use i_mmap_rwsem to fix page fault/truncate race Mike Kravetz
2018-12-19 1:24 ` Sasha Levin
2018-12-21 10:28 ` Kirill A. Shutemov
2018-12-21 18:28 ` Mike Kravetz
2018-12-21 20:21 ` Kirill A. Shutemov
2018-12-21 22:17 ` Mike Kravetz
2018-12-22 22:14 ` Kirill A. Shutemov [this message]
2018-12-20 21:06 ` [PATCH v2 0/2] hugetlbfs: use i_mmap_rwsem for better synchronization Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181222221411.ktm5qeebi43lvce5@kshutemo-mobl1 \
--to=kirill@shutemov.name \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=dave@stgolabs.net \
--cc=hughd@google.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=mike.kravetz@oracle.com \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=prakash.sangappa@oracle.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox