From: Oscar Salvador <osalvador@suse.de>
To: Michal Hocko <mhocko@kernel.org>
Cc: Wei Yang <richard.weiyang@gmail.com>,
akpm@linux-foundation.org, vbabka@suse.cz,
pavel.tatashin@microsoft.com, rppt@linux.vnet.ibm.com,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] mm, page_alloc: Fix has_unmovable_pages for HugePages
Date: Thu, 20 Dec 2018 16:37:34 +0100 [thread overview]
Message-ID: <20181220153731.mpc757cyf2zyr6fm@d104.suse.de> (raw)
In-Reply-To: <20181220143939.GA6210@dhcp22.suse.cz>
On Thu, Dec 20, 2018 at 03:39:39PM +0100, Michal Hocko wrote:
> Yes, you are missing that this code should be as sane as possible ;) You
> are right that we are only processing one pageorder worth of pfns and
> that the page order is bound to HUGETLB_PAGE_ORDER _right_now_. But
> there is absolutely zero reason to hardcode that assumption into a
> simple loop, right?
Of course, it makes sense to keep the code as sane as possible.
This is why I said I was not against the change, but I wanted to
see if I was missing something else besides the assumption.
Thanks
--
Oscar Salvador
SUSE L3
next prev parent reply other threads:[~2018-12-20 15:37 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-17 22:51 Oscar Salvador
2018-12-17 23:07 ` Andrew Morton
2018-12-18 7:36 ` Michal Hocko
2018-12-18 21:46 ` Andrew Morton
2018-12-18 21:51 ` Oscar Salvador
2018-12-19 14:25 ` Wei Yang
2018-12-19 14:28 ` Wei Yang
2018-12-19 23:39 ` Oscar Salvador
2018-12-20 9:12 ` Michal Hocko
2018-12-20 12:49 ` Oscar Salvador
2018-12-20 13:06 ` Michal Hocko
2018-12-20 13:41 ` Oscar Salvador
2018-12-20 14:21 ` Oscar Salvador
2018-12-20 14:39 ` Michal Hocko
2018-12-20 15:37 ` Oscar Salvador [this message]
2018-12-20 15:32 ` Wei Yang
2018-12-20 15:32 ` Wei Yang
2018-12-20 15:52 ` Oscar Salvador
2018-12-20 13:08 ` Wei Yang
2018-12-20 13:49 ` Oscar Salvador
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181220153731.mpc757cyf2zyr6fm@d104.suse.de \
--to=osalvador@suse.de \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=pavel.tatashin@microsoft.com \
--cc=richard.weiyang@gmail.com \
--cc=rppt@linux.vnet.ibm.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox