From: Wei Yang <richard.weiyang@gmail.com>
To: Oscar Salvador <osalvador@suse.de>
Cc: Michal Hocko <mhocko@kernel.org>,
Wei Yang <richard.weiyang@gmail.com>,
akpm@linux-foundation.org, vbabka@suse.cz,
pavel.tatashin@microsoft.com, rppt@linux.vnet.ibm.com,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] mm, page_alloc: Fix has_unmovable_pages for HugePages
Date: Thu, 20 Dec 2018 13:08:57 +0000 [thread overview]
Message-ID: <20181220130857.yrzv5wzmiw7jbycb@master> (raw)
In-Reply-To: <20181220124925.itwuuacgztpgsk7s@d104.suse.de>
On Thu, Dec 20, 2018 at 01:49:28PM +0100, Oscar Salvador wrote:
>On Thu, Dec 20, 2018 at 10:12:28AM +0100, Michal Hocko wrote:
>> > <--
>> > skip_pages = (1 << compound_order(head)) - (page - head);
>> > iter = skip_pages - 1;
>> > --
>> >
>> > which looks more simple IMHO.
>>
>> Agreed!
>
>Andrew, can you please apply the next diff chunk on top of the patch:
>
>diff --git a/mm/page_alloc.c b/mm/page_alloc.c
>index 4812287e56a0..978576d93783 100644
>--- a/mm/page_alloc.c
>+++ b/mm/page_alloc.c
>@@ -8094,7 +8094,7 @@ bool has_unmovable_pages(struct zone *zone, struct page *page, int count,
> goto unmovable;
>
> skip_pages = (1 << compound_order(head)) - (page - head);
>- iter = round_up(iter + 1, skip_pages) - 1;
>+ iter = skip_pages - 1;
This complicated the calculation.
The original code is correct.
iter = round_up(iter + 1, 1<<compound_order(head)) - 1;
> continue;
> }
>
>Thanks!
>--
>Oscar Salvador
>SUSE L3
--
Wei Yang
Help you, Help me
next prev parent reply other threads:[~2018-12-20 13:09 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-17 22:51 Oscar Salvador
2018-12-17 23:07 ` Andrew Morton
2018-12-18 7:36 ` Michal Hocko
2018-12-18 21:46 ` Andrew Morton
2018-12-18 21:51 ` Oscar Salvador
2018-12-19 14:25 ` Wei Yang
2018-12-19 14:28 ` Wei Yang
2018-12-19 23:39 ` Oscar Salvador
2018-12-20 9:12 ` Michal Hocko
2018-12-20 12:49 ` Oscar Salvador
2018-12-20 13:06 ` Michal Hocko
2018-12-20 13:41 ` Oscar Salvador
2018-12-20 14:21 ` Oscar Salvador
2018-12-20 14:39 ` Michal Hocko
2018-12-20 15:37 ` Oscar Salvador
2018-12-20 15:32 ` Wei Yang
2018-12-20 15:32 ` Wei Yang
2018-12-20 15:52 ` Oscar Salvador
2018-12-20 13:08 ` Wei Yang [this message]
2018-12-20 13:49 ` Oscar Salvador
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181220130857.yrzv5wzmiw7jbycb@master \
--to=richard.weiyang@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=osalvador@suse.de \
--cc=pavel.tatashin@microsoft.com \
--cc=rppt@linux.vnet.ibm.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox