From: kbuild test robot <lkp@intel.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: kbuild-all@01.org, akpm@linux-foundation.org,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Keith Busch <keith.busch@intel.com>,
peterz@infradead.org, dave.hansen@linux.intel.com,
linux-mm@kvack.org, x86@kernel.org, linux-kernel@vger.kernel.org,
mgorman@suse.de
Subject: Re: [PATCH v6 1/6] acpi: Create subtable parsing infrastructure
Date: Tue, 18 Dec 2018 21:39:49 +0800 [thread overview]
Message-ID: <201812182126.tR18M3fq%fengguang.wu@intel.com> (raw)
In-Reply-To: <154510700824.1941238.14650493839997144294.stgit@dwillia2-desk3.amr.corp.intel.com>
[-- Attachment #1: Type: text/plain, Size: 4813 bytes --]
Hi Keith,
I love your patch! Yet something to improve:
[auto build test ERROR on linus/master]
[also build test ERROR on v4.20-rc7 next-20181218]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Dan-Williams/mm-Randomize-free-memory/20181218-130230
config: arm64-defconfig (attached as .config)
compiler: aarch64-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.2.0 make.cross ARCH=arm64
All errors (new ones prefixed by >>):
arch/arm64/kernel/smp.c: In function 'acpi_parse_and_init_cpus':
>> arch/arm64/kernel/smp.c:577:11: error: passing argument 2 of 'acpi_table_parse_madt' from incompatible pointer type [-Werror=incompatible-pointer-types]
acpi_parse_gic_cpu_interface, 0);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from arch/arm64/kernel/smp.c:20:0:
include/linux/acpi.h:249:5: note: expected 'acpi_tbl_entry_handler {aka int (*)(union acpi_subtable_headers *, const long unsigned int)}' but argument is of type 'int (*)(struct acpi_subtable_header *, const long unsigned int)'
int acpi_table_parse_madt(enum acpi_madt_type id,
^~~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
--
arch/arm64/kernel/acpi_numa.c: In function 'acpi_map_cpus_to_nodes':
>> arch/arm64/kernel/acpi_numa.c:88:10: error: passing argument 4 of 'acpi_table_parse_entries' from incompatible pointer type [-Werror=incompatible-pointer-types]
acpi_parse_gicc_pxm, 0);
^~~~~~~~~~~~~~~~~~~
In file included from arch/arm64/kernel/acpi_numa.c:19:0:
include/linux/acpi.h:242:12: note: expected 'acpi_tbl_entry_handler {aka int (*)(union acpi_subtable_headers *, const long unsigned int)}' but argument is of type 'int (*)(struct acpi_subtable_header *, const long unsigned int)'
int __init acpi_table_parse_entries(char *id, unsigned long table_size,
^~~~~~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
vim +/acpi_table_parse_madt +577 arch/arm64/kernel/smp.c
e1896249 Lorenzo Pieralisi 2018-06-25 566
e1896249 Lorenzo Pieralisi 2018-06-25 567 static void __init acpi_parse_and_init_cpus(void)
e1896249 Lorenzo Pieralisi 2018-06-25 568 {
e1896249 Lorenzo Pieralisi 2018-06-25 569 int i;
e1896249 Lorenzo Pieralisi 2018-06-25 570
e1896249 Lorenzo Pieralisi 2018-06-25 571 /*
e1896249 Lorenzo Pieralisi 2018-06-25 572 * do a walk of MADT to determine how many CPUs
e1896249 Lorenzo Pieralisi 2018-06-25 573 * we have including disabled CPUs, and get information
e1896249 Lorenzo Pieralisi 2018-06-25 574 * we need for SMP init.
e1896249 Lorenzo Pieralisi 2018-06-25 575 */
e1896249 Lorenzo Pieralisi 2018-06-25 576 acpi_table_parse_madt(ACPI_MADT_TYPE_GENERIC_INTERRUPT,
e1896249 Lorenzo Pieralisi 2018-06-25 @577 acpi_parse_gic_cpu_interface, 0);
e1896249 Lorenzo Pieralisi 2018-06-25 578
e1896249 Lorenzo Pieralisi 2018-06-25 579 /*
e1896249 Lorenzo Pieralisi 2018-06-25 580 * In ACPI, SMP and CPU NUMA information is provided in separate
e1896249 Lorenzo Pieralisi 2018-06-25 581 * static tables, namely the MADT and the SRAT.
e1896249 Lorenzo Pieralisi 2018-06-25 582 *
e1896249 Lorenzo Pieralisi 2018-06-25 583 * Thus, it is simpler to first create the cpu logical map through
e1896249 Lorenzo Pieralisi 2018-06-25 584 * an MADT walk and then map the logical cpus to their node ids
e1896249 Lorenzo Pieralisi 2018-06-25 585 * as separate steps.
e1896249 Lorenzo Pieralisi 2018-06-25 586 */
e1896249 Lorenzo Pieralisi 2018-06-25 587 acpi_map_cpus_to_nodes();
e1896249 Lorenzo Pieralisi 2018-06-25 588
e1896249 Lorenzo Pieralisi 2018-06-25 589 for (i = 0; i < nr_cpu_ids; i++)
e1896249 Lorenzo Pieralisi 2018-06-25 590 early_map_cpu_to_node(i, acpi_numa_get_nid(i));
e1896249 Lorenzo Pieralisi 2018-06-25 591 }
0f078336 Lorenzo Pieralisi 2015-05-13 592 #else
e1896249 Lorenzo Pieralisi 2018-06-25 593 #define acpi_parse_and_init_cpus(...) do { } while (0)
0f078336 Lorenzo Pieralisi 2015-05-13 594 #endif
0f078336 Lorenzo Pieralisi 2015-05-13 595
:::::: The code at line 577 was first introduced by commit
:::::: e189624916961c735c18e3c75acc478661403830 arm64: numa: rework ACPI NUMA initialization
:::::: TO: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
:::::: CC: Will Deacon <will.deacon@arm.com>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 40931 bytes --]
next prev parent reply other threads:[~2018-12-18 13:40 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-18 4:23 [PATCH v6 0/6] mm: Randomize free memory Dan Williams
2018-12-18 4:23 ` [PATCH v6 1/6] acpi: Create subtable parsing infrastructure Dan Williams
2018-12-18 12:45 ` kbuild test robot
2018-12-18 13:39 ` kbuild test robot [this message]
2018-12-18 4:23 ` [PATCH v6 2/6] acpi: Add HMAT to generic parsing tables Dan Williams
2018-12-18 4:23 ` [PATCH v6 3/6] acpi/numa: Set the memory-side-cache size in memblocks Dan Williams
2018-12-18 8:20 ` kbuild test robot
2018-12-18 4:23 ` [PATCH v6 4/6] mm: Shuffle initial free memory to improve memory-side-cache utilization Dan Williams
2018-12-18 6:30 ` kbuild test robot
2018-12-18 4:23 ` [PATCH v6 5/6] mm: Move buddy list manipulations into helpers Dan Williams
2018-12-18 4:23 ` [PATCH v6 6/6] mm: Maintain randomization of page free lists Dan Williams
2018-12-19 20:32 ` [PATCH v6 0/6] mm: Randomize free memory Michal Hocko
2018-12-19 20:55 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201812182126.tR18M3fq%fengguang.wu@intel.com \
--to=lkp@intel.com \
--cc=akpm@linux-foundation.org \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=kbuild-all@01.org \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=peterz@infradead.org \
--cc=rafael.j.wysocki@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox