From: Michal Hocko <mhocko@kernel.org>
To: Hou Tao <houtao1@huawei.com>
Cc: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
Matthew Wilcox <willy@infradead.org>,
phillip@squashfs.org.uk, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] squashfs: enable __GFP_FS in ->readpage to prevent hang in mem alloc
Date: Tue, 18 Dec 2018 12:32:30 +0100 [thread overview]
Message-ID: <20181218113230.GI30879@dhcp22.suse.cz> (raw)
In-Reply-To: <5ba9aba1-e00d-ae07-caf0-3e7eca7de4b6@huawei.com>
On Tue 18-12-18 14:06:11, Hou Tao wrote:
[...]
> In my understanding (correct me if I am wrong), there are three ways through which
> reclamation will invoked fs related code and may cause dead-lock:
>
> (1) write-back dirty pages. Not possible for squashfs.
only from kswapd context. So not relevant to OOM killer/
> (2) the reclamation of inodes & dentries. The current file is in-use, so it will be not
> reclaimed, and for other reclaimable inodes, squashfs_destroy_inode() will
> be invoked and it doesn't take any locks.
There are other inodes, not only those in use. Do you use any locks that
could be taken from an inode teardown?
--
Michal Hocko
SUSE Labs
prev parent reply other threads:[~2018-12-18 11:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-04 2:08 Hou Tao
2018-12-06 1:14 ` Hou Tao
2018-12-13 2:18 ` Hou Tao
2018-12-15 13:24 ` Hou Tao
2018-12-15 14:38 ` Matthew Wilcox
2018-12-16 9:38 ` Hou Tao
2018-12-17 3:51 ` Matthew Wilcox
2018-12-17 9:33 ` Michal Hocko
2018-12-17 10:51 ` Tetsuo Handa
2018-12-17 12:25 ` Matthew Wilcox
2018-12-17 14:10 ` Michal Hocko
2018-12-17 14:41 ` Matthew Wilcox
2018-12-17 14:49 ` Michal Hocko
2018-12-18 6:06 ` Hou Tao
2018-12-18 11:32 ` Michal Hocko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181218113230.GI30879@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=houtao1@huawei.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=phillip@squashfs.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox