linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Huang Ying <ying.huang@intel.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Huang Ying <ying.huang@intel.com>,
	Vineeth Remanan Pillai <vpillai@digitalocean.com>,
	Kelley Nielsen <kelleynnn@gmail.com>,
	Rik van Riel <riel@surriel.com>,
	Matthew Wilcox <willy@infradead.org>,
	Hugh Dickins <hughd@google.com>
Subject: [PATCH -V9 01/21] swap: Deal with PTE mapped THP when unuse PTE
Date: Fri, 14 Dec 2018 14:27:34 +0800	[thread overview]
Message-ID: <20181214062754.13723-2-ying.huang@intel.com> (raw)
In-Reply-To: <20181214062754.13723-1-ying.huang@intel.com>

A PTE swap entry may map to a normal swap slot inside a huge swap
cluster.  To free the huge swap cluster and the corresponding
THP (transparent huge page), all PTE swap entry mappings need to be
unmapped.  The original implementation only checks current PTE swap
entry mapping, this is fixed via calling try_to_free_swap() instead,
which will check all PTE swap mappings inside the huge swap cluster.

This fix could be folded into the patch: mm, swap: rid swapoff of
quadratic complexity in -mm patchset.

Signed-off-by: "Huang, Ying" <ying.huang@intel.com>
Cc: Vineeth Remanan Pillai <vpillai@digitalocean.com>
Cc: Kelley Nielsen <kelleynnn@gmail.com>
Cc: Rik van Riel <riel@surriel.com>
Cc: Matthew Wilcox <willy@infradead.org>
Cc: Hugh Dickins <hughd@google.com>
---
 mm/swapfile.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/mm/swapfile.c b/mm/swapfile.c
index 7464d0a92869..9e6da494781f 100644
--- a/mm/swapfile.c
+++ b/mm/swapfile.c
@@ -1921,10 +1921,8 @@ static int unuse_pte_range(struct vm_area_struct *vma, pmd_t *pmd,
 			goto out;
 		}
 
-		if (PageSwapCache(page) && (swap_count(*swap_map) == 0))
-			delete_from_swap_cache(compound_head(page));
+		try_to_free_swap(page);
 
-		SetPageDirty(page);
 		unlock_page(page);
 		put_page(page);
 
-- 
2.18.1

  reply	other threads:[~2018-12-14  6:27 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-14  6:27 [PATCH -V9 00/21] swap: Swapout/swapin THP in one piece Huang Ying
2018-12-14  6:27 ` Huang Ying [this message]
2018-12-14  6:27 ` [PATCH -V9 02/21] swap: Enable PMD swap operations for CONFIG_THP_SWAP Huang Ying
2018-12-14  6:27 ` [PATCH -V9 03/21] swap: Add __swap_duplicate_locked() Huang Ying
2018-12-14  6:27 ` [PATCH -V9 04/21] swap: Support PMD swap mapping in swap_duplicate() Huang Ying
2018-12-14  6:27 ` [PATCH -V9 05/21] swap: Support PMD swap mapping in put_swap_page() Huang Ying
2018-12-14  6:27 ` [PATCH -V9 06/21] swap: Support PMD swap mapping in free_swap_and_cache()/swap_free() Huang Ying
2018-12-14  6:27 ` [PATCH -V9 07/21] swap: Support PMD swap mapping when splitting huge PMD Huang Ying
2018-12-18 20:54   ` Daniel Jordan
2018-12-19  3:15     ` Huang, Ying
2018-12-14  6:27 ` [PATCH -V9 08/21] swap: Support PMD swap mapping in split_swap_cluster() Huang Ying
2018-12-14  6:27 ` [PATCH -V9 09/21] swap: Support to read a huge swap cluster for swapin a THP Huang Ying
2018-12-14  6:27 ` [PATCH -V9 10/21] swap: Swapin a THP in one piece Huang Ying
2018-12-18 20:56   ` Daniel Jordan
2018-12-19  1:52     ` Huang, Ying
2018-12-14  6:27 ` [PATCH -V9 11/21] swap: Support to count THP swapin and its fallback Huang Ying
2018-12-14  6:27 ` [PATCH -V9 12/21] swap: Add sysfs interface to configure THP swapin Huang Ying
2018-12-14  6:27 ` [PATCH -V9 13/21] swap: Support PMD swap mapping in swapoff Huang Ying
2018-12-14  6:27 ` [PATCH -V9 14/21] swap: Support PMD swap mapping in madvise_free() Huang Ying
2018-12-14  6:27 ` [PATCH -V9 15/21] swap: Support to move swap account for PMD swap mapping Huang Ying
2018-12-14  6:27 ` [PATCH -V9 16/21] swap: Support to copy PMD swap mapping when fork() Huang Ying
2018-12-14  6:27 ` [PATCH -V9 17/21] swap: Free PMD swap mapping when zap_huge_pmd() Huang Ying
2018-12-14  6:27 ` [PATCH -V9 18/21] swap: Support PMD swap mapping for MADV_WILLNEED Huang Ying
2018-12-14  6:27 ` [PATCH -V9 19/21] swap: Support PMD swap mapping in mincore() Huang Ying
2018-12-14  6:27 ` [PATCH -V9 20/21] swap: Support PMD swap mapping in common path Huang Ying
2018-12-14  6:27 ` [PATCH -V9 21/21] swap: create PMD swap mapping when unmap the THP Huang Ying

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181214062754.13723-2-ying.huang@intel.com \
    --to=ying.huang@intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=hughd@google.com \
    --cc=kelleynnn@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=riel@surriel.com \
    --cc=vpillai@digitalocean.com \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox