From: Wei Yang <richard.weiyang@gmail.com>
To: Rong Chen <rong.a.chen@intel.com>
Cc: Wei Yang <richard.weiyang@gmail.com>,
kbuild test robot <lkp@intel.com>,
kbuild-all@01.org, linux-mm@kvack.org,
mgorman@techsingularity.net, akpm@linux-foundation.org
Subject: Re: [PATCH 1/2] mm, pageblock: make sure pageblock won't exceed mem_sectioin
Date: Thu, 13 Dec 2018 07:28:28 +0000 [thread overview]
Message-ID: <20181213072828.zzfl3guhtc3mbdfa@master> (raw)
In-Reply-To: <b036dab0-6822-3a8f-b2ce-4a979506172d@intel.com>
On Thu, Dec 13, 2018 at 01:02:21PM +0800, Rong Chen wrote:
>
>
>On 12/13/2018 11:08 AM, Wei Yang wrote:
>> On Thu, Dec 13, 2018 at 10:26:41AM +0800, Rong Chen wrote:
>> >
>> > On 12/09/2018 08:03 PM, Wei Yang wrote:
>> > > On Sat, Dec 08, 2018 at 09:42:29AM +0800, kbuild test robot wrote:
>> > > > Hi Wei,
>> > > >
>> > > > Thank you for the patch! Perhaps something to improve:
>> > > >
>> > > > [auto build test WARNING on linus/master]
>> > > > [also build test WARNING on v4.20-rc5 next-20181207]
>> > > > [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
>> > > >
>> > > > url: https://github.com/0day-ci/linux/commits/Wei-Yang/mm-pageblock-make-sure-pageblock-won-t-exceed-mem_sectioin/20181207-030601
>> > > > config: powerpc-allmodconfig (attached as .config)
>> > > > compiler: powerpc64-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
>> > > > reproduce:
>> > > > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>> > > > chmod +x ~/bin/make.cross
>> > > > # save the attached .config to linux build tree
>> > > > GCC_VERSION=7.2.0 make.cross ARCH=powerpc
>> > > >
>> > > > All warnings (new ones prefixed by >>):
>> > > >
>> > > > In file included from include/linux/gfp.h:6:0,
>> > > > from include/linux/xarray.h:14,
>> > > > from include/linux/radix-tree.h:31,
>> > > > from include/linux/fs.h:15,
>> > > > from include/linux/compat.h:17,
>> > > > from arch/powerpc/kernel/asm-offsets.c:16:
>> > > > > > include/linux/mmzone.h:1088:6: warning: "pageblock_order" is not defined, evaluates to 0 [-Wundef]
>> > > > #if (pageblock_order + PAGE_SHIFT) > SECTION_SIZE_BITS
>> > > > ^~~~~~~~~~~~~~~
>> > > > --
>> > > > In file included from include/linux/gfp.h:6:0,
>> > > > from include/linux/mm.h:10,
>> > > > from mm//swap.c:16:
>> > > > > > include/linux/mmzone.h:1088:6: warning: "pageblock_order" is not defined, evaluates to 0 [-Wundef]
>> > > > #if (pageblock_order + PAGE_SHIFT) > SECTION_SIZE_BITS
>> > > > ^~~~~~~~~~~~~~~
>> > > > In file included from include/linux/gfp.h:6:0,
>> > > > from include/linux/mm.h:10,
>> > > > from mm//swap.c:16:
>> > > > > > include/linux/mmzone.h:1088:6: warning: "pageblock_order" is not defined, evaluates to 0 [-Wundef]
>> > > > #if (pageblock_order + PAGE_SHIFT) > SECTION_SIZE_BITS
>> > > > ^~~~~~~~~~~~~~~
>> > > >
>> > > > vim +/pageblock_order +1088 include/linux/mmzone.h
>> > > >
>> > > > 1087
>> > > > > 1088 #if (pageblock_order + PAGE_SHIFT) > SECTION_SIZE_BITS
>> > > > 1089 #error Allocator pageblock_order exceeds SECTION_SIZE
>> > > > 1090 #endif
>> > > > 1091
>> > > >
>> > > I took a look at the latest code, at line 1082 of the same file uses
>> > > pageblock_order. And I apply this patch on top of v4.20-rc5, the build
>> > > looks good to me.
>> > >
>> > > Confused why this introduce an compile error.
>> > Hi Wei,
>> >
>> > we could reproduce the warnings with using make.cross.
>> >
>> That's interesting.
>>
>> Do you see this file already use pageblock_order in line 1081?
>>
>> Is this one report warning?
>>
>
>both questions is yes.
>
Sounds interesting :-)
I don't have a power machine and we may drop this patch as discussed, so
I won't look into this now.
Thanks for your effort.
>Best Regards,
>Rong Chen
>
>
--
Wei Yang
Help you, Help me
next prev parent reply other threads:[~2018-12-13 7:28 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-05 9:19 Wei Yang
2018-12-05 9:19 ` [PATCH 2/2] mm, page_alloc: cleanup usemap_size() when SPARSEMEM is not set Wei Yang
2018-12-07 9:58 ` Wei Yang
2018-12-05 11:15 ` [PATCH 1/2] mm, pageblock: make sure pageblock won't exceed mem_sectioin Mel Gorman
2018-12-05 12:08 ` Wei Yang
2018-12-05 15:37 ` Mel Gorman
2018-12-05 22:31 ` Wei Yang
2018-12-06 9:00 ` David Hildenbrand
2018-12-06 9:21 ` Wei Yang
2018-12-06 9:26 ` David Hildenbrand
2018-12-06 9:42 ` Wei Yang
2018-12-08 1:42 ` kbuild test robot
2018-12-09 12:03 ` Wei Yang
2018-12-13 2:26 ` Rong Chen
2018-12-13 3:08 ` Wei Yang
2018-12-13 5:02 ` Rong Chen
2018-12-13 7:28 ` Wei Yang [this message]
2018-12-09 13:58 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181213072828.zzfl3guhtc3mbdfa@master \
--to=richard.weiyang@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=kbuild-all@01.org \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
--cc=mgorman@techsingularity.net \
--cc=rong.a.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox