From: kbuild test robot <lkp@intel.com>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>
Cc: kbuild-all@01.org, npiggin@gmail.com, benh@kernel.crashing.org,
paulus@samba.org, mpe@ellerman.id.au, akpm@linux-foundation.org,
linuxppc-dev@lists.ozlabs.org, linux-mm@kvack.org
Subject: Re: [PATCH V3 updated] arch/powerpc/mm/hugetlb: NestMMU workaround for hugetlb mprotect RW upgrade
Date: Sat, 8 Dec 2018 09:04:41 +0800 [thread overview]
Message-ID: <201812080954.gLWCs0dp%fengguang.wu@intel.com> (raw)
In-Reply-To: <20181205041146.8481-1-aneesh.kumar@linux.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 1926 bytes --]
Hi Aneesh,
I love your patch! Yet something to improve:
[auto build test ERROR on powerpc/next]
[also build test ERROR on v4.20-rc5 next-20181207]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Aneesh-Kumar-K-V/arch-powerpc-mm-hugetlb-NestMMU-workaround-for-hugetlb-mprotect-RW-upgrade/20181207-025514
base: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next
config: powerpc-allmodconfig (attached as .config)
compiler: powerpc64-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.2.0 make.cross ARCH=powerpc
All errors (new ones prefixed by >>):
arch/powerpc/mm/hugetlbpage-radix.c: In function 'radix__huge_ptep_modify_prot_commit':
>> arch/powerpc/mm/hugetlbpage-radix.c:104:6: error: implicit declaration of function 'is_pte_rw_upgrade' [-Werror=implicit-function-declaration]
if (is_pte_rw_upgrade(pte_val(old_pte), pte_val(pte)) &&
^~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
vim +/is_pte_rw_upgrade +104 arch/powerpc/mm/hugetlbpage-radix.c
93
94 void radix__huge_ptep_modify_prot_commit(struct vm_area_struct *vma,
95 unsigned long addr, pte_t *ptep,
96 pte_t old_pte, pte_t pte)
97 {
98 struct mm_struct *mm = vma->vm_mm;
99
100 /*
101 * To avoid NMMU hang while relaxing access we need to flush the tlb before
102 * we set the new value.
103 */
> 104 if (is_pte_rw_upgrade(pte_val(old_pte), pte_val(pte)) &&
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 59386 bytes --]
prev parent reply other threads:[~2018-12-08 1:05 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-05 3:09 [PATCH V3 0/5] NestMMU pte upgrade workaround for mprotect Aneesh Kumar K.V
2018-12-05 3:09 ` [PATCH V3 1/5] mm: Update ptep_modify_prot_start/commit to take vm_area_struct as arg Aneesh Kumar K.V
2018-12-06 21:58 ` kbuild test robot
2018-12-08 15:32 ` Aneesh Kumar K.V
2018-12-05 3:09 ` [PATCH V3 2/5] mm: update ptep_modify_prot_commit to take old pte value " Aneesh Kumar K.V
2018-12-05 4:02 ` Christophe LEROY
2018-12-05 4:06 ` Aneesh Kumar K.V
2018-12-05 4:42 ` Christophe LEROY
2018-12-05 3:09 ` [PATCH V3 3/5] arch/powerpc/mm: Nest MMU workaround for mprotect RW upgrade Aneesh Kumar K.V
2018-12-18 17:21 ` Christoph Hellwig
2018-12-05 3:09 ` [PATCH V3 4/5] mm/hugetlb: Add prot_modify_start/commit sequence for hugetlb update Aneesh Kumar K.V
2018-12-05 3:09 ` [PATCH V3 5/5] arch/powerpc/mm/hugetlb: NestMMU workaround for hugetlb mprotect RW upgrade Aneesh Kumar K.V
2018-12-05 3:57 ` Christophe LEROY
2018-12-05 4:09 ` Aneesh Kumar K.V
2018-12-05 4:11 ` [PATCH V3 updated] " Aneesh Kumar K.V
2018-12-08 1:04 ` kbuild test robot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201812080954.gLWCs0dp%fengguang.wu@intel.com \
--to=lkp@intel.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=kbuild-all@01.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox