From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-f198.google.com (mail-oi1-f198.google.com [209.85.167.198]) by kanga.kvack.org (Postfix) with ESMTP id 28BB26B7AD3 for ; Thu, 6 Dec 2018 11:17:15 -0500 (EST) Received: by mail-oi1-f198.google.com with SMTP id n196so419672oig.15 for ; Thu, 06 Dec 2018 08:17:15 -0800 (PST) Received: from foss.arm.com (usa-sjc-mx-foss1.foss.arm.com. [217.140.101.70]) by mx.google.com with ESMTP id d134si301785oib.261.2018.12.06.08.17.13 for ; Thu, 06 Dec 2018 08:17:13 -0800 (PST) Date: Thu, 6 Dec 2018 16:17:08 +0000 From: Catalin Marinas Subject: Re: [PATCH v7 13/25] KVM: arm/arm64: Add kvm_ras.h to collect kvm specific RAS plumbing Message-ID: <20181206161707.GL54495@arrakis.emea.arm.com> References: <20181203180613.228133-1-james.morse@arm.com> <20181203180613.228133-14-james.morse@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181203180613.228133-14-james.morse@arm.com> Sender: owner-linux-mm@kvack.org List-ID: To: James Morse Cc: linux-acpi@vger.kernel.org, Rafael Wysocki , Tony Luck , Fan Wu , Xie XiuQi , Marc Zyngier , Will Deacon , Christoffer Dall , Dongjiu Geng , linux-mm@kvack.org, Borislav Petkov , Naoya Horiguchi , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, Len Brown On Mon, Dec 03, 2018 at 06:06:01PM +0000, James Morse wrote: > To split up APEIs in_nmi() path, the caller needs to always be > in_nmi(). KVM shouldn't have to know about this, pull the RAS plumbing > out into a header file. > > Currently guest synchronous external aborts are claimed as RAS > notifications by handle_guest_sea(), which is hidden in the arch codes > mm/fault.c. 32bit gets a dummy declaration in system_misc.h. > > There is going to be more of this in the future if/when the kernel > supports the SError-based firmware-first notification mechanism and/or > kernel-first notifications for both synchronous external abort and > SError. Each of these will come with some Kconfig symbols and a > handful of header files. > > Create a header file for all this. > > This patch gives handle_guest_sea() a 'kvm_' prefix, and moves the > declarations to kvm_ras.h as preparation for a future patch that moves > the ACPI-specific RAS code out of mm/fault.c. > > Signed-off-by: James Morse > Reviewed-by: Punit Agrawal > Acked-by: Marc Zyngier > Tested-by: Tyler Baicar For the arm64 bits here: Acked-by: Catalin Marinas