linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Mel Gorman <mgorman@suse.de>
To: kbuild test robot <lkp@intel.com>
Cc: kbuild-all@01.org, Johannes Weiner <hannes@cmpxchg.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Linux Memory Management List <linux-mm@kvack.org>
Subject: Re: [mmotm:master 128/293] kernel/sysctl.o:undefined reference to `fragment_stall_order_sysctl_handler'
Date: Wed, 5 Dec 2018 11:20:01 +0000	[thread overview]
Message-ID: <20181205112001.GD31508@suse.de> (raw)
In-Reply-To: <201812051704.QejGRMmV%fengguang.wu@intel.com>

On Wed, Dec 05, 2018 at 05:12:06PM +0800, kbuild test robot wrote:
> tree:   git://git.cmpxchg.org/linux-mmotm.git master
> head:   7072a0ce81c613d27563eed5425727d1d8791f58
> commit: e3e68607541c60671eb3499a2c064d2f71626da4 [128/293] mm: stall movable allocations until kswapd progresses during serious external fragmentation event
> config: c6x-evmc6678_defconfig (attached as .config)
> compiler: c6x-elf-gcc (GCC) 8.1.0
> reproduce:
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         git checkout e3e68607541c60671eb3499a2c064d2f71626da4
>         # save the attached .config to linux build tree
>         GCC_VERSION=8.1.0 make.cross ARCH=c6x 
> 
> All errors (new ones prefixed by >>):
> 

This appears to be some sort of glitch in Andrew's tree. It works in
mmots and is broken in mmotm. The problem is that with mmotm, the
fragment_stall_order_sysctl_handler handler has moved below
sysctl_min_slab_ratio_sysctl_handler instead of below
watermark_boost_factor_sysctl_handler where it belongs.

Now, while this could be fixed, in this specific instance I would prefer
the patch be dropped entirely because there are some potential downsides
that are potentially distracting and the supporting data is not strong
enough too justify the potential downsides.

Andrew?

-- 
Mel Gorman
SUSE Labs

  reply	other threads:[~2018-12-05 11:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-05  9:12 kbuild test robot
2018-12-05 11:20 ` Mel Gorman [this message]
2018-12-07 23:12   ` Andrew Morton
2018-12-05  9:23 kbuild test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181205112001.GD31508@suse.de \
    --to=mgorman@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=hannes@cmpxchg.org \
    --cc=kbuild-all@01.org \
    --cc=linux-mm@kvack.org \
    --cc=lkp@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox