linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Mel Gorman <mgorman@techsingularity.net>
To: Wei Yang <richard.weiyang@gmail.com>
Cc: linux-mm@kvack.org, akpm@linux-foundation.org
Subject: Re: [PATCH 1/2] mm, pageblock: make sure pageblock won't exceed mem_sectioin
Date: Wed, 5 Dec 2018 11:15:13 +0000	[thread overview]
Message-ID: <20181205111513.GA23260@techsingularity.net> (raw)
In-Reply-To: <20181205091905.27727-1-richard.weiyang@gmail.com>

On Wed, Dec 05, 2018 at 05:19:04PM +0800, Wei Yang wrote:
> When SPARSEMEM is used, there is an indication that pageblock is not
> allowed to exceed one mem_section. Current code doesn't have this
> constrain explicitly.
> 
> This patch adds this to make sure it won't.
> 
> Signed-off-by: Wei Yang <richard.weiyang@gmail.com>

Is this even possible? This would imply that the section size is smaller
than max order which would be quite a crazy selection for a sparesemem
section size. A lot of assumptions on the validity of PFNs within a
max-order boundary would be broken with such a section size. I'd be
surprised if such a setup could even boot, let alone run.

-- 
Mel Gorman
SUSE Labs

  parent reply	other threads:[~2018-12-05 11:15 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-05  9:19 Wei Yang
2018-12-05  9:19 ` [PATCH 2/2] mm, page_alloc: cleanup usemap_size() when SPARSEMEM is not set Wei Yang
2018-12-07  9:58   ` Wei Yang
2018-12-05 11:15 ` Mel Gorman [this message]
2018-12-05 12:08   ` [PATCH 1/2] mm, pageblock: make sure pageblock won't exceed mem_sectioin Wei Yang
2018-12-05 15:37     ` Mel Gorman
2018-12-05 22:31       ` Wei Yang
2018-12-06  9:00         ` David Hildenbrand
2018-12-06  9:21           ` Wei Yang
2018-12-06  9:26             ` David Hildenbrand
2018-12-06  9:42               ` Wei Yang
2018-12-08  1:42 ` kbuild test robot
2018-12-09 12:03   ` Wei Yang
2018-12-13  2:26     ` Rong Chen
2018-12-13  3:08       ` Wei Yang
2018-12-13  5:02         ` Rong Chen
2018-12-13  7:28           ` Wei Yang
2018-12-09 13:58 ` kbuild test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181205111513.GA23260@techsingularity.net \
    --to=mgorman@techsingularity.net \
    --cc=akpm@linux-foundation.org \
    --cc=linux-mm@kvack.org \
    --cc=richard.weiyang@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox