From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) by kanga.kvack.org (Postfix) with ESMTP id C110B6B73F3 for ; Wed, 5 Dec 2018 05:59:52 -0500 (EST) Received: by mail-pf1-f200.google.com with SMTP id t72so16442688pfi.21 for ; Wed, 05 Dec 2018 02:59:52 -0800 (PST) Received: from mail.kernel.org (mail.kernel.org. [198.145.29.99]) by mx.google.com with ESMTPS id h36si17454880pgm.200.2018.12.05.02.59.51 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 05 Dec 2018 02:59:51 -0800 (PST) Date: Wed, 5 Dec 2018 11:59:49 +0100 From: Greg Kroah-Hartman Subject: Re: [PATCH v1] drivers/base/memory.c: Use DEVICE_ATTR_RO and friends Message-ID: <20181205105949.GD16376@kroah.com> References: <20181203111611.10633-1-david@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181203111611.10633-1-david@redhat.com> Sender: owner-linux-mm@kvack.org List-ID: To: David Hildenbrand Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, "Rafael J. Wysocki" , Andrew Morton , Ingo Molnar , Pavel Tatashin , Oscar Salvador , Michal Hocko , Wei Yang On Mon, Dec 03, 2018 at 12:16:11PM +0100, David Hildenbrand wrote: > Let's use the easier to read (and not mess up) variants: > - Use DEVICE_ATTR_RO > - Use DEVICE_ATTR_WO > - Use DEVICE_ATTR_RW > instead of the more generic DEVICE_ATTR() we're using right now. > > We have to rename most callback functions. By fixing the intendations we > can even save some LOCs. > > Cc: Greg Kroah-Hartman > Cc: "Rafael J. Wysocki" > Cc: Andrew Morton > Cc: Ingo Molnar > Cc: Pavel Tatashin > Cc: Oscar Salvador > Cc: Michal Hocko > Cc: Wei Yang > Signed-off-by: David Hildenbrand > Reviewed-by: Wei Yang > --- > drivers/base/memory.c | 79 ++++++++++++++++++++----------------------- > 1 file changed, 36 insertions(+), 43 deletions(-) Thanks, I'll take this through my tree. greg k-h