From: Mike Rapoport <rppt@linux.ibm.com>
To: "Adeodato Simó" <dato@net.com.org.es>
Cc: linux-mm@kvack.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 3/3] mm: add missing declaration of memmap_init in linux/mm.h
Date: Tue, 4 Dec 2018 09:48:49 +0200 [thread overview]
Message-ID: <20181204074848.GH26700@rapoport-lnx> (raw)
In-Reply-To: <fccff943020c51f2319b673dd9e5720672e64a6e.1543899764.git.dato@net.com.org.es>
On Tue, Dec 04, 2018 at 02:14:24AM -0300, Adeodato Sim� wrote:
> This follows-up commit dfb3ccd00a06 ("mm: make memmap_init a proper
> function"), which changed memmap_init from macro to function.
>
> Signed-off-by: Adeodato Sim� <dato@net.com.org.es>
Reviewed-by: Mike Rapoport <rppt@linux.ibm.com>
> ---
> scripts/checkpatch.pl complained about use of extern for a prototype,
> but I preferred to maintain consistency with surrounding code. -d
>
> include/linux/mm.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/include/linux/mm.h b/include/linux/mm.h
> index 3eb3bf7774f1..8597b864dd91 100644
> --- a/include/linux/mm.h
> +++ b/include/linux/mm.h
> @@ -2268,6 +2268,8 @@ static inline void zero_resv_unavail(void) {}
> #endif
>
> extern void set_dma_reserve(unsigned long new_dma_reserve);
> +extern void memmap_init(unsigned long size, int nid,
> + unsigned long zone, unsigned long start_pfn);
> extern void memmap_init_zone(unsigned long, int, unsigned long, unsigned long,
> enum memmap_context, struct vmem_altmap *);
> extern void setup_per_zone_wmarks(void);
> --
> 2.19.2
>
--
Sincerely yours,
Mike.
next prev parent reply other threads:[~2018-12-04 7:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-04 5:14 [PATCH 1/3] mm: add include files so that function definitions have a prototype Adeodato Simó
2018-12-04 5:14 ` [PATCH 2/3] mm: move two private functions to static linkage Adeodato Simó
2018-12-04 7:48 ` Mike Rapoport
2018-12-04 5:14 ` [PATCH 3/3] mm: add missing declaration of memmap_init in linux/mm.h Adeodato Simó
2018-12-04 7:48 ` Mike Rapoport [this message]
2018-12-04 7:47 ` [PATCH 1/3] mm: add include files so that function definitions have a prototype Mike Rapoport
2019-01-17 10:36 ` Adeodato Simó
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181204074848.GH26700@rapoport-lnx \
--to=rppt@linux.ibm.com \
--cc=dato@net.com.org.es \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox