From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Hugh Dickins <hughd@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Matthew Wilcox <willy@infradead.org>,
Jerome Glisse <jglisse@redhat.com>,
linux-mm@kvack.org
Subject: Re: [PATCH 01/10] mm/huge_memory: rename freeze_page() to unmap_page()
Date: Tue, 27 Nov 2018 10:24:46 +0300 [thread overview]
Message-ID: <20181127072446.ylceky4fjx7ybe5u@kshutemo-mobl1> (raw)
In-Reply-To: <alpine.LSU.2.11.1811261514080.2275@eggly.anvils>
On Mon, Nov 26, 2018 at 03:16:28PM -0800, Hugh Dickins wrote:
> The term "freeze" is used in several ways in the kernel, and in mm it
> has the particular meaning of forcing page refcount temporarily to 0.
> freeze_page() is just too confusing a name for a function that unmaps
> a page: rename it unmap_page(), and rename unfreeze_page() remap_page().
>
> Went to change the mention of freeze_page() added later in mm/rmap.c,
> but found it to be incorrect: ordinary page reclaim reaches there too;
> but the substance of the comment still seems correct, so edit it down.
>
> Fixes: e9b61f19858a5 ("thp: reintroduce split_huge_page()")
> Signed-off-by: Hugh Dickins <hughd@google.com>
> Cc: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
> Cc: Jerome Glisse <jglisse@redhat.com>
> Cc: stable@vger.kernel.org # 4.8+
Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
--
Kirill A. Shutemov
prev parent reply other threads:[~2018-11-27 7:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-26 23:16 Hugh Dickins
2018-11-27 7:24 ` Kirill A. Shutemov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181127072446.ylceky4fjx7ybe5u@kshutemo-mobl1 \
--to=kirill@shutemov.name \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=jglisse@redhat.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-mm@kvack.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox