From: Vinod Koul <vkoul@kernel.org>
To: Anshuman Khandual <anshuman.khandual@arm.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
ocfs2-devel@oss.oracle.com, linux-fbdev@vger.kernel.org,
dri-devel@lists.freedesktop.org, netdev@vger.kernel.org,
intel-wired-lan@lists.osuosl.org, linux-media@vger.kernel.org,
iommu@lists.linux-foundation.org, linux-rdma@vger.kernel.org,
dmaengine@vger.kernel.org, linux-block@vger.kernel.org,
sparclinux@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-ia64@vger.kernel.org, linux-alpha@vger.kernel.org,
akpm@linux-foundation.org, jiangqi903@gmail.com,
hverkuil@xs4all.nl
Subject: Re: [PATCH] mm: Replace all open encodings for NUMA_NO_NODE
Date: Sat, 24 Nov 2018 19:35:54 +0530 [thread overview]
Message-ID: <20181124140554.GG3175@vkoul-mobl.Dlink> (raw)
In-Reply-To: <1542966856-12619-1-git-send-email-anshuman.khandual@arm.com>
On 23-11-18, 15:24, Anshuman Khandual wrote:
> --- a/drivers/dma/dmaengine.c
> +++ b/drivers/dma/dmaengine.c
> @@ -386,7 +386,8 @@ EXPORT_SYMBOL(dma_issue_pending_all);
> static bool dma_chan_is_local(struct dma_chan *chan, int cpu)
> {
> int node = dev_to_node(chan->device->dev);
> - return node == -1 || cpumask_test_cpu(cpu, cpumask_of_node(node));
> + return node == NUMA_NO_NODE ||
> + cpumask_test_cpu(cpu, cpumask_of_node(node));
> }
I do not see dev_to_node being updated first, that returns -1 so I would
prefer to check for -1 unless it return NUMA_NO_NODE
--
~Vinod
next prev parent reply other threads:[~2018-11-24 14:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-23 9:54 Anshuman Khandual
2018-11-23 10:36 ` David Hildenbrand
2018-11-23 11:16 ` Anshuman Khandual
2018-11-23 23:44 ` Andrew Morton
2018-11-24 11:13 ` Anshuman Khandual
2018-11-24 14:05 ` Vinod Koul [this message]
2018-11-26 6:45 ` Anshuman Khandual
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181124140554.GG3175@vkoul-mobl.Dlink \
--to=vkoul@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=dmaengine@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=hverkuil@xs4all.nl \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=iommu@lists.linux-foundation.org \
--cc=jiangqi903@gmail.com \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=ocfs2-devel@oss.oracle.com \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox