From: Michal Hocko <mhocko@suse.com>
To: Wei Yang <richard.weiyang@gmail.com>
Cc: osalvador@suse.de, akpm@linux-foundation.org, linux-mm@kvack.org
Subject: Re: [PATCH v2] mm, hotplug: move init_currently_empty_zone() under zone_span_lock protection
Date: Thu, 22 Nov 2018 11:29:22 +0100 [thread overview]
Message-ID: <20181122102922.GE18011@dhcp22.suse.cz> (raw)
In-Reply-To: <20181122101557.pzq6ggiymn52gfqk@master>
On Thu 22-11-18 10:15:57, Wei Yang wrote:
> On Thu, Nov 22, 2018 at 06:12:41PM +0800, Wei Yang wrote:
> >During online_pages phase, pgdat->nr_zones will be updated in case this
> >zone is empty.
> >
> >Currently the online_pages phase is protected by the global lock
> >mem_hotplug_begin(), which ensures there is no contention during the
> >update of nr_zones. But this global lock introduces scalability issues.
> >
> >This patch is a preparation for removing the global lock during
> >online_pages phase. Also this patch changes the documentation of
> >node_size_lock to include the protectioin of nr_zones.
I would just add that the patch moves init_currently_empty_zone under
both zone_span_writelock and pgdat_resize_lock because both the pgdat
state is changed (nr_zones) and the zone's start_pfn
> >
> >Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
>
> Missed this, if I am correct. :-)
>
> Acked-by: Michal Hocko <mhocko@suse.com>
Yes, thank you.
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2018-11-22 10:29 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-20 1:48 [PATCH] mm, hotplug: protect nr_zones with pgdat_resize_lock() Wei Yang
2018-11-20 7:31 ` Michal Hocko
2018-11-20 7:58 ` osalvador
2018-11-20 8:48 ` Michal Hocko
2018-11-21 2:52 ` Wei Yang
2018-11-21 7:15 ` Michal Hocko
2018-11-22 1:52 ` Wei Yang
2018-11-22 8:39 ` Michal Hocko
2018-11-26 2:28 ` Wei Yang
2018-11-26 8:16 ` Michal Hocko
2018-11-26 9:06 ` Wei Yang
2018-11-26 10:03 ` Michal Hocko
2018-11-27 0:18 ` Wei Yang
2018-11-27 3:12 ` Wei Yang
2018-11-27 13:16 ` Michal Hocko
2018-11-27 23:56 ` Wei Yang
2018-11-21 8:24 ` osalvador
2018-11-21 2:44 ` Wei Yang
2018-11-21 7:14 ` Michal Hocko
2018-11-22 10:12 ` [PATCH v2] mm, hotplug: move init_currently_empty_zone() under zone_span_lock protection Wei Yang
2018-11-22 10:15 ` Wei Yang
2018-11-22 10:29 ` Michal Hocko [this message]
2018-11-22 14:27 ` Wei Yang
2018-11-22 10:37 ` osalvador
2018-11-22 14:28 ` Wei Yang
2018-11-22 15:26 ` David Hildenbrand
2018-11-22 21:28 ` Wei Yang
2018-11-22 21:53 ` David Hildenbrand
2018-11-22 23:53 ` Wei Yang
2018-11-23 8:42 ` Michal Hocko
2018-11-23 8:46 ` David Hildenbrand
2018-11-26 1:44 ` Wei Yang
2018-11-26 9:24 ` David Hildenbrand
2018-11-27 0:23 ` Wei Yang
2018-11-30 6:58 ` [PATCH v3] " Wei Yang
2018-11-30 9:30 ` David Hildenbrand
2018-12-01 0:27 ` Wei Yang
2018-12-03 10:09 ` David Hildenbrand
2018-12-03 20:37 ` Wei Yang
2018-12-03 20:50 ` [PATCH v4] " Wei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181122102922.GE18011@dhcp22.suse.cz \
--to=mhocko@suse.com \
--cc=akpm@linux-foundation.org \
--cc=linux-mm@kvack.org \
--cc=osalvador@suse.de \
--cc=richard.weiyang@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox