From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Andrea Arcangeli <aarcange@redhat.com>
Cc: Mel Gorman <mgorman@techsingularity.net>,
Anthony Yznaga <anthony.yznaga@oracle.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
aneesh.kumar@linux.ibm.com, akpm@linux-foundation.org,
jglisse@redhat.com, khandual@linux.vnet.ibm.com,
kirill.shutemov@linux.intel.com, mhocko@kernel.org,
minchan@kernel.org, peterz@infradead.org, rientjes@google.com,
vbabka@suse.cz, willy@infradead.org, ying.huang@intel.com,
nitingupta910@gmail.com
Subject: Re: [RFC PATCH] mm: thp: implement THP reservations for anonymous memory
Date: Tue, 20 Nov 2018 12:11:22 +0300 [thread overview]
Message-ID: <20181120091122.3dxlgff3vivwilrg@kshutemo-mobl1> (raw)
In-Reply-To: <20181110164412.GB22642@redhat.com>
On Sat, Nov 10, 2018 at 11:44:12AM -0500, Andrea Arcangeli wrote:
> I would prefer to add intelligence to detect when COWs after fork
> should be done at 2m or 4k granularity (in the latter case by
> splitting the pmd before the actual COW while leaving the transhuge
> pmd intact in the other mm), because that would save CPU (and it'd
> automatically optimize redis). The snapshot process especially would
> run faster as it will read with THP performance.
I would argue we should switch to 4k COW everywhere. But it requires some
work on khugepaged side to be able to recover THP back after multiple 4k
COW in the range. Currently khugepaged is not able to collapse PTE entires
backed by compound page back to PMD.
I have this on my todo list for long time, but...
--
Kirill A. Shutemov
next prev parent reply other threads:[~2018-11-20 9:11 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-09 6:48 Anthony Yznaga
2018-11-09 11:07 ` Mel Gorman
2018-11-09 23:37 ` anthony.yznaga
2018-11-09 12:13 ` Kirill A. Shutemov
2018-11-09 13:11 ` Mel Gorman
2018-11-09 15:34 ` Zi Yan
2018-11-10 0:39 ` anthony.yznaga
2018-11-10 9:35 ` Kirill A. Shutemov
2018-11-09 19:51 ` Andrea Arcangeli
2018-11-10 0:55 ` anthony.yznaga
2018-11-10 13:22 ` Mel Gorman
2018-11-10 16:44 ` Andrea Arcangeli
2018-11-14 23:15 ` anthony.yznaga
2019-01-25 2:28 ` Anthony Yznaga
2018-11-20 9:11 ` Kirill A. Shutemov [this message]
2018-11-20 17:04 ` Andrea Arcangeli
2018-11-10 0:04 ` anthony.yznaga
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181120091122.3dxlgff3vivwilrg@kshutemo-mobl1 \
--to=kirill@shutemov.name \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.ibm.com \
--cc=anthony.yznaga@oracle.com \
--cc=jglisse@redhat.com \
--cc=khandual@linux.vnet.ibm.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=mhocko@kernel.org \
--cc=minchan@kernel.org \
--cc=nitingupta910@gmail.com \
--cc=peterz@infradead.org \
--cc=rientjes@google.com \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox