From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: stable@vger.kernel.org,
Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Tejun Heo <tj@kernel.org>,
akpm@linux-foundation.org, linux-mm@kvack.org,
Cong Wang <xiyou.wangcong@gmail.com>,
Dave Hansen <dave.hansen@intel.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Mel Gorman <mgorman@suse.de>, Michal Hocko <mhocko@kernel.org>,
Vlastimil Babka <vbabka@suse.cz>,
Peter Zijlstra <peterz@infradead.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Jan Kara <jack@suse.cz>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Byungchul Park <byungchul.park@lge.com>,
Pavel Machek <pavel@ucw.cz>, Steven Rostedt <rostedt@goodmis.org>,
Petr Mladek <pmladek@suse.com>
Subject: Re: request for 4.14-stable: fd5f7cde1b85 ("printk: Never set console_may_schedule in console_trylock()")
Date: Tue, 20 Nov 2018 11:23:15 +0900 [thread overview]
Message-ID: <20181120022315.GA4231@jagdpanzerIV> (raw)
In-Reply-To: <20181119151807.GE5340@kroah.com>
On (11/19/18 16:18), Greg Kroah-Hartman wrote:
> On Sun, Nov 11, 2018 at 08:20:45PM +0000, Sudip Mukherjee wrote:
> > Hi Greg,
> >
> > This was not marked for stable but seems it should be in stable.
> > Please apply to your queue of 4.14-stable.
>
> Now queued up, thanks.
Very sorry for the late reply!
Greg, Sudip, the commit in question is known to be controversial. It
does fix some lockups, but it also does make printk non-atomic in some
cases: the printing task can get preempted which can cause printk
stalls (no messages on serial consoles, until the printing task gets
rescheduled again) in some dark-corner cases.
I think Tetsuo is the only person who ever reported printk stalls,
probably because he is the only person who is testing very tough
OOM-scenarios on a regular basis.
So, long story short, I call that commit "a mistake" and we have
reverted it upstream, to make printk always atomic (just like it
should be).
As of printk lockups, Steven Rostedt has contributed a much better
solution.
-ss
next prev parent reply other threads:[~2018-11-20 2:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-11 20:20 Sudip Mukherjee
2018-11-19 15:18 ` Greg Kroah-Hartman
2018-11-20 2:23 ` Sergey Senozhatsky [this message]
2018-11-20 2:28 ` Sergey Senozhatsky
2018-11-20 7:42 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181120022315.GA4231@jagdpanzerIV \
--to=sergey.senozhatsky.work@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=byungchul.park@lge.com \
--cc=dave.hansen@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hannes@cmpxchg.org \
--cc=jack@suse.cz \
--cc=linux-mm@kvack.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mgorman@suse.de \
--cc=mhocko@kernel.org \
--cc=pavel@ucw.cz \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=peterz@infradead.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky@gmail.com \
--cc=stable@vger.kernel.org \
--cc=sudipm.mukherjee@gmail.com \
--cc=tj@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=vbabka@suse.cz \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox