From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) by kanga.kvack.org (Postfix) with ESMTP id 1D1F96B054E for ; Thu, 15 Nov 2018 13:49:30 -0500 (EST) Received: by mail-ed1-f72.google.com with SMTP id i55so1301757ede.14 for ; Thu, 15 Nov 2018 10:49:30 -0800 (PST) Received: from mx1.suse.de (mx2.suse.de. [195.135.220.15]) by mx.google.com with ESMTPS id u2-v6si2817765ejo.76.2018.11.15.10.49.28 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 15 Nov 2018 10:49:28 -0800 (PST) Date: Thu, 15 Nov 2018 10:49:17 -0800 From: Davidlohr Bueso Subject: Re: [PATCH tip/core/rcu 6/7] mm: Replace spin_is_locked() with lockdep Message-ID: <20181115184917.6goqg67hpojfhk42@linux-r8p5> References: <20181111200421.GA10551@linux.ibm.com> <20181111200443.10772-6-paulmck@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20181111200443.10772-6-paulmck@linux.ibm.com> Sender: owner-linux-mm@kvack.org List-ID: To: "Paul E. McKenney" Cc: linux-kernel@vger.kernel.org, mingo@kernel.org, jiangshanlai@gmail.com, dipankar@in.ibm.com, akpm@linux-foundation.org, mathieu.desnoyers@efficios.com, josh@joshtriplett.org, tglx@linutronix.de, peterz@infradead.org, rostedt@goodmis.org, dhowells@redhat.com, edumazet@google.com, fweisbec@gmail.com, oleg@redhat.com, joel@joelfernandes.org, Lance Roy , "Kirill A. Shutemov" , Yang Shi , Matthew Wilcox , Mel Gorman , Jan Kara , Shakeel Butt , linux-mm@kvack.org On Sun, 11 Nov 2018, Paul E. McKenney wrote: >From: Lance Roy > >lockdep_assert_held() is better suited to checking locking requirements, >since it only checks if the current thread holds the lock regardless of >whether someone else does. This is also a step towards possibly removing >spin_is_locked(). So fyi I'm not crazy about these kind of patches simply because lockdep is a lot less used out of anything that's not a lab, and we can be missing potential offenders. There's obviously nothing wrong about what you describe above perse, just my two cents. Thansk, Davidlohr