From: Wei Yang <richard.weiyang@gmail.com>
To: akpm@linux-foundation.org, mgorman@techsingularity.net
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Wei Yang <richard.weiyang@gmail.com>
Subject: [PATCH] vmscan: return NODE_RECLAIM_NOSCAN in node_reclaim() when CONFIG_NUMA is n
Date: Tue, 13 Nov 2018 12:17:50 +0800 [thread overview]
Message-ID: <20181113041750.20784-1-richard.weiyang@gmail.com> (raw)
Commit fa5e084e43eb ("vmscan: do not unconditionally treat zones that
fail zone_reclaim() as full") changed the return value of node_reclaim().
The original return value 0 means NODE_RECLAIM_SOME after this commit.
While the return value of node_reclaim() when CONFIG_NUMA is n is not
changed. This will leads to call zone_watermark_ok() again.
This patch fix the return value by adjusting to NODE_RECLAIM_NOSCAN. Since
it is not proper to include "mm/internal.h", just hard coded it.
Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
---
This doesn't effect the system functionally. I am not sure we need to cc to
stable tree?
---
include/linux/swap.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/swap.h b/include/linux/swap.h
index d8a07a4f171d..2bd993280470 100644
--- a/include/linux/swap.h
+++ b/include/linux/swap.h
@@ -364,7 +364,7 @@ extern int node_reclaim(struct pglist_data *, gfp_t, unsigned int);
static inline int node_reclaim(struct pglist_data *pgdat, gfp_t mask,
unsigned int order)
{
- return 0;
+ return -2; /* NODE_RECLAIM_NOSCAN */
}
#endif
--
2.15.1
next reply other threads:[~2018-11-13 4:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-13 4:17 Wei Yang [this message]
2018-11-13 5:36 ` Matthew Wilcox
2018-11-13 7:49 ` Wei Yang
2018-11-13 8:04 ` [PATCH v2] " Wei Yang
2018-11-13 12:56 ` Michal Hocko
2018-11-13 13:18 ` Wei Yang
2018-11-13 13:04 ` Matthew Wilcox
2018-11-13 13:18 ` Wei Yang
2018-11-13 13:32 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181113041750.20784-1-richard.weiyang@gmail.com \
--to=richard.weiyang@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox