From: Sean Christopherson <sean.j.christopherson@intel.com>
To: Dave Hansen <dave.hansen@intel.com>
Cc: Marc Orr <marcorr@google.com>,
kvm@vger.kernel.org, jmattson@google.com, rientjes@google.com,
konrad.wilk@oracle.com, linux-mm@kvack.org,
akpm@linux-foundation.org, pbonzini@redhat.com,
rkrcmar@redhat.com, willy@infradead.org,
dave.hansen@linux.intel.com, kernellwp@gmail.com
Subject: Re: [kvm PATCH v5 3/4] kvm: vmx: refactor vmx_msrs struct for vmalloc
Date: Wed, 31 Oct 2018 07:15:48 -0700 [thread overview]
Message-ID: <20181031141547.GA13907@linux.intel.com> (raw)
In-Reply-To: <ea8abaf5-8c8b-1484-c6d7-e5d110e45f48@intel.com>
On Wed, Oct 31, 2018 at 07:12:16AM -0700, Dave Hansen wrote:
> On 10/31/18 6:26 AM, Marc Orr wrote:
> > +/*
> > + * To prevent vmx_msr_entry array from crossing a page boundary, require:
> > + * sizeof(*vmx_msrs.vmx_msr_entry.val) to be a power of two. This is guaranteed
> > + * through compile-time asserts that:
> > + * - NR_AUTOLOAD_MSRS * sizeof(struct vmx_msr_entry) is a power of two
> > + * - NR_AUTOLOAD_MSRS * sizeof(struct vmx_msr_entry) <= PAGE_SIZE
> > + * - The allocation of vmx_msrs.vmx_msr_entry.val is aligned to its size.
> > + */
>
> Why do we need to prevent them from crossing a page boundary?
The VMCS takes the physical address of the load/store lists. I
requested that this information be added to the changelog. Marc
deferred addressing my comments since there's a decent chance
patches 3/4 and 4/4 will be dropped in the end.
next prev parent reply other threads:[~2018-10-31 14:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-31 13:26 [kvm PATCH v5 0/4] shrink vcpu_vmx down to order 2 Marc Orr
2018-10-31 13:26 ` [kvm PATCH v5 1/4] kvm: x86: Use task structs fpu field for user Marc Orr
2018-10-31 13:26 ` [kvm PATCH v5 2/4] kvm: x86: Dynamically allocate guest_fpu Marc Orr
2018-10-31 14:11 ` Dave Hansen
2018-10-31 21:13 ` Marc Orr
2018-10-31 21:21 ` Dave Hansen
2018-10-31 21:24 ` Marc Orr
2018-10-31 21:30 ` Dave Hansen
2018-10-31 21:39 ` Marc Orr
2018-10-31 21:44 ` Dave Hansen
2018-10-31 13:26 ` [kvm PATCH v5 3/4] kvm: vmx: refactor vmx_msrs struct for vmalloc Marc Orr
2018-10-31 14:12 ` Dave Hansen
2018-10-31 14:15 ` Sean Christopherson [this message]
2018-10-31 14:19 ` Marc Orr
2018-10-31 13:26 ` [kvm PATCH v5 4/4] kvm: vmx: use vmalloc() to allocate vcpus Marc Orr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181031141547.GA13907@linux.intel.com \
--to=sean.j.christopherson@intel.com \
--cc=akpm@linux-foundation.org \
--cc=dave.hansen@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=jmattson@google.com \
--cc=kernellwp@gmail.com \
--cc=konrad.wilk@oracle.com \
--cc=kvm@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=marcorr@google.com \
--cc=pbonzini@redhat.com \
--cc=rientjes@google.com \
--cc=rkrcmar@redhat.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox