From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: Li Wang <liwang@redhat.com>, Guenter Roeck <linux@roeck-us.net>,
Janosch Frank <frankja@linux.vnet.ibm.com>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
Linux-MM <linux-mm@kvack.org>
Subject: Re: [PATCH 1/3] mm: introduce mm_[p4d|pud|pmd]_folded
Date: Wed, 31 Oct 2018 12:48:41 +0300 [thread overview]
Message-ID: <20181031094841.cawzzoddkemmufwl@kshutemo-mobl1> (raw)
In-Reply-To: <20181031103536.0cab673d@mschwideX1>
On Wed, Oct 31, 2018 at 10:35:36AM +0100, Martin Schwidefsky wrote:
> > Maybe
> > return __is_defined(__PAGETABLE_P4D_FOLDED);
> >
> > ?
>
> I have tried that, doesn't work. The reason is that the
> __PAGETABLE_xxx_FOLDED defines to not have a value.
>
> #define __PAGETABLE_P4D_FOLDED
> #define __PAGETABLE_PMD_FOLDED
> #define __PAGETABLE_PUD_FOLDED
>
> While the definition of CONFIG_xxx symbols looks like this
>
> #define CONFIG_xxx 1
>
> The __is_defined needs the value for the __take_second_arg trick.
I guess this is easily fixable :)
--
Kirill A. Shutemov
next prev parent reply other threads:[~2018-10-31 9:48 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-15 16:42 [RFC][PATCH 0/3] pgtable bytes mis-accounting v2 Martin Schwidefsky
2018-10-15 16:42 ` [PATCH 1/3] mm: introduce mm_[p4d|pud|pmd]_folded Martin Schwidefsky
2018-10-31 9:02 ` Kirill A. Shutemov
2018-10-31 9:35 ` Martin Schwidefsky
2018-10-31 9:48 ` Kirill A. Shutemov [this message]
2018-10-15 16:42 ` [PATCH 2/3] mm: add mm_pxd_folded checks to pgtable_bytes accounting functions Martin Schwidefsky
2018-10-31 9:04 ` Kirill A. Shutemov
2018-10-15 16:42 ` [PATCH 3/3] s390/mm: fix mis-accounting of pgtable_bytes Martin Schwidefsky
2018-10-31 6:18 ` Li Wang
2018-10-31 6:31 ` Martin Schwidefsky
2018-10-31 6:43 ` Li Wang
2018-10-31 6:46 ` Martin Schwidefsky
2018-10-31 9:39 ` Martin Schwidefsky
2018-10-31 10:09 ` Heiko Carstens
2018-10-31 10:36 ` Kirill A. Shutemov
2018-11-27 7:34 ` Heiko Carstens
2018-11-27 8:05 ` Kirill A. Shutemov
2018-11-27 8:13 ` Heiko Carstens
2018-11-27 11:47 ` Guenter Roeck
2018-11-27 11:52 ` Heiko Carstens
2018-11-27 14:31 ` Martin Schwidefsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181031094841.cawzzoddkemmufwl@kshutemo-mobl1 \
--to=kirill@shutemov.name \
--cc=frankja@linux.vnet.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux@roeck-us.net \
--cc=liwang@redhat.com \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox