From: Michal Hocko <mhocko@kernel.org>
To: Marc Orr <marcorr@google.com>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
linux-mm@kvack.org, akpm@linux-foundation.org,
kvm@vger.kernel.org, Jim Mattson <jmattson@google.com>,
David Rientjes <rientjes@google.com>
Subject: Re: [kvm PATCH 1/2] mm: export __vmalloc_node_range()
Date: Wed, 24 Oct 2018 10:22:17 +0200 [thread overview]
Message-ID: <20181024082217.GC18839@dhcp22.suse.cz> (raw)
In-Reply-To: <CAA03e5Gw1UsFRtQ2drnkXteDFj1J_+PXe0RLjXnCEytZdL4gUw@mail.gmail.com>
Please do not top-post
On Wed 24-10-18 09:12:52, Marc Orr wrote:
> No. I separated them because they're going to two different subsystems
> (i.e., mm and kvm).
Yes, they do go to two different subsystems but they would have to
coordinate for the final merge because the later wouldn't work without
the former. So it is easier to have them in a single tree. From the
review POV it is better to have them in the single patch to see the
usecase for the export and judge whether this is the best option.
> I'll fold them and resend the patch.
Thanks!
> On Wed, Oct 24, 2018 at 7:16 AM Michal Hocko <mhocko@kernel.org> wrote:
> >
> > On Tue 23-10-18 17:10:55, Marc Orr wrote:
> > > Ack. The user is the 2nd patch in this series, the kvm_intel module,
> > > which uses this version of vmalloc() to allocate vcpus across
> > > non-contiguous memory. I will cc everyone here on that 2nd patch for
> > > context.
> >
> > Is there any reason to not fold those two into a single one?
> > --
> > Michal Hocko
> > SUSE Labs
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2018-10-24 8:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20181020211200.255171-1-marcorr@google.com>
[not found] ` <20181020211200.255171-2-marcorr@google.com>
2018-10-22 20:06 ` Konrad Rzeszutek Wilk
2018-10-23 12:33 ` Michal Hocko
2018-10-23 21:10 ` Marc Orr
2018-10-24 6:16 ` Michal Hocko
2018-10-24 8:12 ` Marc Orr
2018-10-24 8:22 ` Michal Hocko [this message]
2018-10-23 21:13 ` [kvm PATCH 0/2] kvm: vmalloc vmx vcpus Marc Orr
[not found] ` <20181020211200.255171-3-marcorr@google.com>
2018-10-23 21:13 ` [kvm PATCH 2/2] kvm: vmx: use vmalloc() to allocate vcpus Marc Orr
2018-10-24 11:41 ` Matthew Wilcox
2018-10-24 18:05 ` Marc Orr
2018-10-25 12:58 ` Michal Hocko
2018-10-24 22:31 ` Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181024082217.GC18839@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=jmattson@google.com \
--cc=konrad.wilk@oracle.com \
--cc=kvm@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=marcorr@google.com \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox