Re: [kvm PATCH 1/2] mm: export __vmalloc_node_range()

[Michal Hocko <mhocko@kernel.org>]

On Mon 22-10-18 16:06:17, Konrad Rzeszutek Wilk wrote:
> On Sat, Oct 20, 2018 at 02:11:59PM -0700, Marc Orr wrote:
> > The __vmalloc_node_range() is in the include/linux/vmalloc.h file, but
> > it's not exported so it can't be used. This patch exports the API. The
> > motivation to export it is so that we can do aligned vmalloc's of KVM
> > vcpus.
> 
> Would it make more sense to change it to not have __ in front of it?
> Also you forgot to CC the linux-mm folks. Doing that for you.

Please also add a user so that we can see how the symbol is actually
used with a short explanation why the existing API is not suitable.

> > 
> > Signed-off-by: Marc Orr <marcorr@google.com>
> > ---
> >  mm/vmalloc.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/mm/vmalloc.c b/mm/vmalloc.c
> > index a728fc492557..9e7974ab1da4 100644
> > --- a/mm/vmalloc.c
> > +++ b/mm/vmalloc.c
> > @@ -1763,6 +1763,7 @@ void *__vmalloc_node_range(unsigned long size, unsigned long align,
> >  			  "vmalloc: allocation failure: %lu bytes", real_size);
> >  	return NULL;
> >  }
> > +EXPORT_SYMBOL_GPL(__vmalloc_node_range);
> >  
> >  /**
> >   *	__vmalloc_node  -  allocate virtually contiguous memory
> > -- 
> > 2.19.1.568.g152ad8e336-goog
> > 

-- 
Michal Hocko
SUSE Labs