From: Wei Yang <richard.weiyang@gmail.com>
To: Pavel Tatashin <pasha.tatashin@gmail.com>
Cc: penghao122@sina.com.cn,
Linux Memory Management List <linux-mm@kvack.org>,
Andrew Morton <akpm@linux-foundation.org>,
pasha.tatashin@oracle.com, osalvador@suse.de,
LKML <linux-kernel@vger.kernel.org>,
peng.hao2@zte.com.cn
Subject: Re: [PATCH] mm/sparse: remove a check that compare if unsigned variable is negative
Date: Fri, 19 Oct 2018 08:28:01 +0000 [thread overview]
Message-ID: <20181019082801.kbnqxx5ozghy3p3b@master> (raw)
In-Reply-To: <CAGM2reYqEpY9KbMDU6uSaCuzsyN6qcXit930vbWk54PLhvZxZg@mail.gmail.com>
On Sat, Oct 13, 2018 at 01:04:45PM -0400, Pavel Tatashin wrote:
>This is incorrect: next_present_section_nr() returns "int" and -1 no
>next section, this change would lead to infinite loop.
Yes, the -1 is a very special value.
--
Wei Yang
Help you, Help me
prev parent reply other threads:[~2018-10-19 8:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-13 16:15 Peng Hao
2018-10-13 17:04 ` Pavel Tatashin
2018-10-15 1:08 ` [PATCH] mm/sparse: remove a check that compare if unsignedvariable " peng.hao2
2018-10-19 8:28 ` Wei Yang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181019082801.kbnqxx5ozghy3p3b@master \
--to=richard.weiyang@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=osalvador@suse.de \
--cc=pasha.tatashin@gmail.com \
--cc=pasha.tatashin@oracle.com \
--cc=peng.hao2@zte.com.cn \
--cc=penghao122@sina.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox