From: Joel Fernandes <joel@joelfernandes.org>
To: "Kirill A. Shutemov" <kirill@shutemov.name>
Cc: g@kshutemo-mobl1.kvack.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, kernel-team@android.com, minchan@google.com,
hughd@google.com, lokeshgidra@google.com,
Andrew Morton <akpm@linux-foundation.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Kate Stewart <kstewart@linuxfoundation.org>,
Philippe Ombredanne <pombredanne@nexb.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] mm: Speed up mremap on large regions
Date: Thu, 11 Oct 2018 18:47:25 -0700 [thread overview]
Message-ID: <20181012014725.GA12431@joelaf.mtv.corp.google.com> (raw)
In-Reply-To: <20181011081111.mfbhuantvxmkd33p@kshutemo-mobl1>
On Thu, Oct 11, 2018 at 11:11:11AM +0300, Kirill A. Shutemov wrote:
> On Thu, Oct 11, 2018 at 08:14:19AM +0300, Kirill A. Shutemov wrote:
> > On Wed, Oct 10, 2018 at 05:46:18PM -0700, Joel Fernandes wrote:
> > > diff --git a/arch/powerpc/include/asm/book3s/64/pgalloc.h b/arch/powerpc/include/asm/book3s/64/pgalloc.h
> > > index 391ed2c3b697..8a33f2044923 100644
> > > --- a/arch/powerpc/include/asm/book3s/64/pgalloc.h
> > > +++ b/arch/powerpc/include/asm/book3s/64/pgalloc.h
> > > @@ -192,14 +192,12 @@ static inline pgtable_t pmd_pgtable(pmd_t pmd)
> > > return (pgtable_t)pmd_page_vaddr(pmd);
> > > }
> > >
> > > -static inline pte_t *pte_alloc_one_kernel(struct mm_struct *mm,
> > > - unsigned long address)
> > > +static inline pte_t *pte_alloc_one_kernel(struct mm_struct *mm)
> > > {
> > > return (pte_t *)pte_fragment_alloc(mm, address, 1);
> > > }
> >
> > This is obviously broken.
I was actually aware of this, I was in the early stages of writing the script
but just shared the diff to give an idea the number of changes.
> I've checked pte_fragment_alloc() and it doesn't use the address too.
> We need to modify it too.
I rewrote the Coccinelle script and manually fixed pte_fragment_alloc in
that. I sent an update with you and Michal on CC, please check it. Thanks a
lot.
- Joel
next prev parent reply other threads:[~2018-10-12 1:47 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-09 20:14 Joel Fernandes (Google)
2018-10-09 21:38 ` Andrew Morton
2018-10-09 23:08 ` Joel Fernandes
2018-10-09 22:02 ` Kirill A. Shutemov
2018-10-09 23:04 ` Joel Fernandes
2018-10-10 10:00 ` Kirill A. Shutemov
2018-10-11 0:46 ` Joel Fernandes
2018-10-11 0:50 ` Joel Fernandes
2018-10-11 5:14 ` Kirill A. Shutemov
2018-10-11 8:11 ` Kirill A. Shutemov
2018-10-12 1:47 ` Joel Fernandes [this message]
2018-10-11 8:17 ` Kirill A. Shutemov
2018-10-11 12:02 ` Michal Hocko
2018-10-12 3:21 ` Jann Horn
2018-10-12 5:29 ` Juergen Gross
2018-10-12 5:34 ` Jann Horn
2018-10-12 7:29 ` Juergen Gross
2018-10-12 7:24 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181012014725.GA12431@joelaf.mtv.corp.google.com \
--to=joel@joelfernandes.org \
--cc=akpm@linux-foundation.org \
--cc=g@kshutemo-mobl1.kvack.org \
--cc=gregkh@linuxfoundation.org \
--cc=hughd@google.com \
--cc=kernel-team@android.com \
--cc=kirill@shutemov.name \
--cc=kstewart@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lokeshgidra@google.com \
--cc=minchan@google.com \
--cc=pombredanne@nexb.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox