From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) by kanga.kvack.org (Postfix) with ESMTP id E29476B000D for ; Thu, 11 Oct 2018 04:11:18 -0400 (EDT) Received: by mail-pg1-f199.google.com with SMTP id q143-v6so5392535pgq.12 for ; Thu, 11 Oct 2018 01:11:18 -0700 (PDT) Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id a12-v6sor23412145pfc.11.2018.10.11.01.11.17 for (Google Transport Security); Thu, 11 Oct 2018 01:11:17 -0700 (PDT) Date: Thu, 11 Oct 2018 11:11:11 +0300 From: "Kirill A. Shutemov" Subject: Re: [PATCH] mm: Speed up mremap on large regions Message-ID: <20181011081111.mfbhuantvxmkd33p@kshutemo-mobl1> References: <20181009201400.168705-1-joel@joelfernandes.org> <20181009220222.26nzajhpsbt7syvv@kshutemo-mobl1> <20181009230447.GA17911@joelaf.mtv.corp.google.com> <20181010100011.6jqjvgeslrvvyhr3@kshutemo-mobl1> <20181011004618.GA237677@joelaf.mtv.corp.google.com> <20181011051419.2rkfbooqc3auk5ji@kshutemo-mobl1> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181011051419.2rkfbooqc3auk5ji@kshutemo-mobl1> Sender: owner-linux-mm@kvack.org List-ID: To: Joel Fernandes , g@kshutemo-mobl1.kvack.org Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel-team@android.com, minchan@google.com, hughd@google.com, lokeshgidra@google.com, Andrew Morton , Greg Kroah-Hartman , Kate Stewart , Philippe Ombredanne , Thomas Gleixner On Thu, Oct 11, 2018 at 08:14:19AM +0300, Kirill A. Shutemov wrote: > On Wed, Oct 10, 2018 at 05:46:18PM -0700, Joel Fernandes wrote: > > diff --git a/arch/powerpc/include/asm/book3s/64/pgalloc.h b/arch/powerpc/include/asm/book3s/64/pgalloc.h > > index 391ed2c3b697..8a33f2044923 100644 > > --- a/arch/powerpc/include/asm/book3s/64/pgalloc.h > > +++ b/arch/powerpc/include/asm/book3s/64/pgalloc.h > > @@ -192,14 +192,12 @@ static inline pgtable_t pmd_pgtable(pmd_t pmd) > > return (pgtable_t)pmd_page_vaddr(pmd); > > } > > > > -static inline pte_t *pte_alloc_one_kernel(struct mm_struct *mm, > > - unsigned long address) > > +static inline pte_t *pte_alloc_one_kernel(struct mm_struct *mm) > > { > > return (pte_t *)pte_fragment_alloc(mm, address, 1); > > } > > This is obviously broken. I've checked pte_fragment_alloc() and it doesn't use the address too. We need to modify it too. -- Kirill A. Shutemov