From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J . Wysocki" <rafael@kernel.org>,
Jassi Brar <jassisinghbrar@gmail.com>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Arnd Bergmann <arnd@arndb.de>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-arch@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH v6 0/4] devres: provide and use devm_kstrdup_const()
Date: Mon, 1 Oct 2018 19:09:01 +0300 [thread overview]
Message-ID: <20181001160901.GY15943@smile.fi.intel.com> (raw)
In-Reply-To: <20180930202615.12951-1-brgl@bgdev.pl>
On Sun, Sep 30, 2018 at 10:26:11PM +0200, Bartosz Golaszewski wrote:
> This series implements devm_kstrdup_const() together with some
> prerequisite changes and uses it in tegra-hsp driver.
Thanks!
For the first three,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> v1 -> v2:
> - fixed the changelog in the patch implementing devm_kstrdup_const()
> - fixed the kernel doc
> - moved is_kernel_rodata() to asm-generic/sections.h
> - fixed constness
>
> v2 -> v3:
> - rebased on top of 4.19-rc5 as there were some conflicts in the
> pmc-atom driver
> - collected Reviewed-by tags
>
> v3 -> v4:
> - Andy NAK'ed patch 4/4 so I added a different example
> - collected more tags
>
> v4 -> v5:
> - instead of providing devm_kfree_const(), make devm_kfree() check if
> given pointer is not in .rodata and act accordingly
>
> v5 -> v6:
> - fixed the commit message in patch 2/4 (s/devm_kfree_const/devm_kfree/)
> - collected even more tags
>
> Bartosz Golaszewski (4):
> devres: constify p in devm_kfree()
> mm: move is_kernel_rodata() to asm-generic/sections.h
> devres: provide devm_kstrdup_const()
> mailbox: tegra-hsp: use devm_kstrdup_const()
>
> drivers/base/devres.c | 36 +++++++++++++++++++++++++++--
> drivers/mailbox/tegra-hsp.c | 41 ++++++++--------------------------
> include/asm-generic/sections.h | 14 ++++++++++++
> include/linux/device.h | 4 +++-
> mm/util.c | 7 ------
> 5 files changed, 60 insertions(+), 42 deletions(-)
>
> --
> 2.18.0
>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2018-10-01 16:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-30 20:26 Bartosz Golaszewski
2018-09-30 20:26 ` [PATCH v6 1/4] devres: constify p in devm_kfree() Bartosz Golaszewski
2018-09-30 20:26 ` [PATCH v6 2/4] mm: move is_kernel_rodata() to asm-generic/sections.h Bartosz Golaszewski
2018-09-30 20:26 ` [PATCH v6 3/4] devres: provide devm_kstrdup_const() Bartosz Golaszewski
2018-09-30 20:26 ` [PATCH v6 4/4] mailbox: tegra-hsp: use devm_kstrdup_const() Bartosz Golaszewski
2018-10-01 16:09 ` Andy Shevchenko [this message]
2018-10-03 8:33 ` [PATCH v6 0/4] devres: provide and " Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181001160901.GY15943@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=brgl@bgdev.pl \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=jassisinghbrar@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=rafael@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox