From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ot1-f72.google.com (mail-ot1-f72.google.com [209.85.210.72]) by kanga.kvack.org (Postfix) with ESMTP id E0C528E0001 for ; Sat, 29 Sep 2018 06:31:50 -0400 (EDT) Received: by mail-ot1-f72.google.com with SMTP id q12-v6so9857879otf.20 for ; Sat, 29 Sep 2018 03:31:50 -0700 (PDT) Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com. [148.163.158.5]) by mx.google.com with ESMTPS id v192-v6si3561585oie.56.2018.09.29.03.31.49 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 29 Sep 2018 03:31:49 -0700 (PDT) Received: from pps.filterd (m0098413.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w8TATsCI086921 for ; Sat, 29 Sep 2018 06:31:49 -0400 Received: from e06smtp01.uk.ibm.com (e06smtp01.uk.ibm.com [195.75.94.97]) by mx0b-001b2d01.pphosted.com with ESMTP id 2mt3j0x4wx-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Sat, 29 Sep 2018 06:31:49 -0400 Received: from localhost by e06smtp01.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Sat, 29 Sep 2018 11:31:47 +0100 Date: Sat, 29 Sep 2018 13:31:39 +0300 From: Mike Rapoport Subject: Re: [PATCH 2/3] userfaultfd: selftest: generalize read and poll References: <20180929084311.15600-1-peterx@redhat.com> <20180929084311.15600-3-peterx@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180929084311.15600-3-peterx@redhat.com> Message-Id: <20180929103138.GB6429@rapoport-lnx> Sender: owner-linux-mm@kvack.org List-ID: To: Peter Xu Cc: linux-kernel@vger.kernel.org, Shuah Khan , Jerome Glisse , Mike Kravetz , linux-mm@kvack.org, Zi Yan , "Kirill A . Shutemov" , linux-kselftest@vger.kernel.org, Shaohua Li , Andrea Arcangeli , "Dr . David Alan Gilbert" , Andrew Morton On Sat, Sep 29, 2018 at 04:43:10PM +0800, Peter Xu wrote: > We do very similar things in read and poll modes, but we're copying the > codes around. Share the codes properly on reading the message and > handling the page fault to make the code cleaner. Meanwhile this solves > previous mismatch of behaviors between the two modes on that the old > code: > > - did not check EAGAIN case in read() mode > - ignored BOUNCE_VERIFY check in read() mode > > Signed-off-by: Peter Xu > --- > tools/testing/selftests/vm/userfaultfd.c | 76 +++++++++++++----------- > 1 file changed, 42 insertions(+), 34 deletions(-) > > diff --git a/tools/testing/selftests/vm/userfaultfd.c b/tools/testing/selftests/vm/userfaultfd.c > index 2a84adaf8cf8..f79706f13ce7 100644 > --- a/tools/testing/selftests/vm/userfaultfd.c > +++ b/tools/testing/selftests/vm/userfaultfd.c > @@ -449,6 +449,42 @@ static int copy_page(int ufd, unsigned long offset) > return __copy_page(ufd, offset, false); > } > > +static int uffd_read_msg(int ufd, struct uffd_msg *msg) > +{ > + int ret = read(uffd, msg, sizeof(*msg)); > + > + if (ret != sizeof(*msg)) { > + if (ret < 0) I'd appreciate curly brace here > + if (errno == EAGAIN) > + return 1; > + else > + perror("blocking read error"), exit(1); > + else and here > + fprintf(stderr, "short read\n"), exit(1); > + } > + > + return 0; > +} > + > +/* Return 1 if page fault handled by us; otherwise 0 */ > +static int uffd_handle_page_fault(struct uffd_msg *msg) > +{ > + unsigned long offset; > + > + if (msg->event != UFFD_EVENT_PAGEFAULT) > + fprintf(stderr, "unexpected msg event %u\n", > + msg->event), exit(1); > + > + if (bounces & BOUNCE_VERIFY && > + msg->arg.pagefault.flags & UFFD_PAGEFAULT_FLAG_WRITE) > + fprintf(stderr, "unexpected write fault\n"), exit(1); > + > + offset = (char *)(unsigned long)msg->arg.pagefault.address - area_dst; > + offset &= ~(page_size-1); > + > + return copy_page(uffd, offset); > +} > + > static void *uffd_poll_thread(void *arg) > { > unsigned long cpu = (unsigned long) arg; > @@ -456,7 +492,6 @@ static void *uffd_poll_thread(void *arg) > struct uffd_msg msg; > struct uffdio_register uffd_reg; > int ret; > - unsigned long offset; > char tmp_chr; > unsigned long userfaults = 0; > > @@ -480,25 +515,15 @@ static void *uffd_poll_thread(void *arg) > if (!(pollfd[0].revents & POLLIN)) > fprintf(stderr, "pollfd[0].revents %d\n", > pollfd[0].revents), exit(1); > - ret = read(uffd, &msg, sizeof(msg)); > - if (ret < 0) { > - if (errno == EAGAIN) > - continue; > - perror("nonblocking read error"), exit(1); > - } > + if (uffd_read_msg(uffd, &msg)) > + continue; > switch (msg.event) { > default: > fprintf(stderr, "unexpected msg event %u\n", > msg.event), exit(1); > break; > case UFFD_EVENT_PAGEFAULT: > - if (msg.arg.pagefault.flags & UFFD_PAGEFAULT_FLAG_WRITE) > - fprintf(stderr, "unexpected write fault\n"), exit(1); > - offset = (char *)(unsigned long)msg.arg.pagefault.address - > - area_dst; > - offset &= ~(page_size-1); > - if (copy_page(uffd, offset)) > - userfaults++; > + userfaults += uffd_handle_page_fault(&msg); > break; > case UFFD_EVENT_FORK: > close(uffd); > @@ -526,8 +551,6 @@ static void *uffd_read_thread(void *arg) > { > unsigned long *this_cpu_userfaults; > struct uffd_msg msg; > - unsigned long offset; > - int ret; > > this_cpu_userfaults = (unsigned long *) arg; > *this_cpu_userfaults = 0; > @@ -536,24 +559,9 @@ static void *uffd_read_thread(void *arg) > /* from here cancellation is ok */ > > for (;;) { > - ret = read(uffd, &msg, sizeof(msg)); > - if (ret != sizeof(msg)) { > - if (ret < 0) > - perror("blocking read error"), exit(1); > - else > - fprintf(stderr, "short read\n"), exit(1); > - } > - if (msg.event != UFFD_EVENT_PAGEFAULT) > - fprintf(stderr, "unexpected msg event %u\n", > - msg.event), exit(1); > - if (bounces & BOUNCE_VERIFY && > - msg.arg.pagefault.flags & UFFD_PAGEFAULT_FLAG_WRITE) > - fprintf(stderr, "unexpected write fault\n"), exit(1); > - offset = (char *)(unsigned long)msg.arg.pagefault.address - > - area_dst; > - offset &= ~(page_size-1); > - if (copy_page(uffd, offset)) > - (*this_cpu_userfaults)++; > + if (uffd_read_msg(uffd, &msg)) > + continue; > + (*this_cpu_userfaults) += uffd_handle_page_fault(&msg); > } > return (void *)NULL; > } > -- > 2.17.1 > -- Sincerely yours, Mike.