From: Michal Hocko <mhocko@kernel.org>
To: Dave Hansen <dave.hansen@intel.com>
Cc: Pasha Tatashin <Pavel.Tatashin@microsoft.com>,
Alexander Duyck <alexander.duyck@gmail.com>,
linux-mm <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
"Duyck, Alexander H" <alexander.h.duyck@intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
Ingo Molnar <mingo@kernel.org>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Subject: Re: [PATCH v2 1/2] mm: Move page struct poisoning to CONFIG_DEBUG_VM_PAGE_INIT_POISON
Date: Thu, 6 Sep 2018 20:08:54 +0200 [thread overview]
Message-ID: <20180906180854.GG14951@dhcp22.suse.cz> (raw)
In-Reply-To: <c5dc8ef6-587d-e286-af80-568094a65007@intel.com>
On Thu 06-09-18 10:07:51, Dave Hansen wrote:
> On 09/06/2018 09:12 AM, Pasha Tatashin wrote:
> >
> > I do not want to make this feature less tested. Poisoning memory allowed
> > us to catch corner case bugs like these:
> >
> > ab1e8d8960b68f54af42b6484b5950bd13a4054b
> > mm: don't allow deferred pages with NEED_PER_CPU_KM
> >
> > e181ae0c5db9544de9c53239eb22bc012ce75033
> > mm: zero unavailable pages before memmap init
> >
> > And several more that were fixed by other people.
>
> Just curious: were these found in the wild, or by a developer doing
> normal development having turned on lots of debug options?
Some of those were 0day AFAIR but my memory is quite dim. Pavel will
know better. The bottom line is, however, that those bugs depend on
strange or unexpected memory configurations or HW which is usually
deployed outside of developers machine pool. So more people have this
enabled the more likely we hit all those strange corner cases nobody
even thought of.
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2018-09-06 18:08 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-05 21:13 [PATCH v2 0/2] Address issues slowing memory init Alexander Duyck
2018-09-05 21:13 ` [PATCH v2 1/2] mm: Move page struct poisoning to CONFIG_DEBUG_VM_PAGE_INIT_POISON Alexander Duyck
2018-09-05 21:22 ` Pasha Tatashin
2018-09-05 21:29 ` Alexander Duyck
2018-09-05 21:38 ` Pasha Tatashin
2018-09-05 21:54 ` Alexander Duyck
2018-09-05 21:34 ` Dave Hansen
2018-09-06 5:47 ` Michal Hocko
2018-09-06 14:59 ` Dave Hansen
2018-09-06 15:13 ` Michal Hocko
2018-09-06 15:41 ` Alexander Duyck
2018-09-06 16:12 ` Pasha Tatashin
2018-09-06 17:07 ` Dave Hansen
2018-09-06 18:08 ` Michal Hocko [this message]
2018-09-06 17:03 ` Michal Hocko
2018-09-06 17:23 ` Pasha Tatashin
2018-09-06 16:09 ` Dave Hansen
2018-09-06 17:08 ` Michal Hocko
2018-09-05 21:13 ` [PATCH v2 2/2] mm: Create non-atomic version of SetPageReserved for init use Alexander Duyck
2018-09-06 5:49 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180906180854.GG14951@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=Pavel.Tatashin@microsoft.com \
--cc=akpm@linux-foundation.org \
--cc=alexander.duyck@gmail.com \
--cc=alexander.h.duyck@intel.com \
--cc=dave.hansen@intel.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox