From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) by kanga.kvack.org (Postfix) with ESMTP id 45D976B77A4 for ; Thu, 6 Sep 2018 03:49:24 -0400 (EDT) Received: by mail-pg1-f200.google.com with SMTP id r2-v6so5138624pgp.3 for ; Thu, 06 Sep 2018 00:49:24 -0700 (PDT) Received: from mx1.suse.de (mx2.suse.de. [195.135.220.15]) by mx.google.com with ESMTPS id q8-v6si4613613pgh.675.2018.09.06.00.49.22 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 06 Sep 2018 00:49:23 -0700 (PDT) Date: Thu, 6 Sep 2018 09:49:19 +0200 From: Michal Hocko Subject: Re: [RFC PATCH 10/29] memblock: replace __alloc_bootmem_node_nopanic with memblock_alloc_try_nid_nopanic Message-ID: <20180906074919.GS14951@dhcp22.suse.cz> References: <1536163184-26356-1-git-send-email-rppt@linux.vnet.ibm.com> <1536163184-26356-11-git-send-email-rppt@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1536163184-26356-11-git-send-email-rppt@linux.vnet.ibm.com> Sender: owner-linux-mm@kvack.org List-ID: To: Mike Rapoport Cc: linux-mm@kvack.org, Andrew Morton , "David S. Miller" , Greg Kroah-Hartman , Ingo Molnar , Michael Ellerman , Paul Burton , Thomas Gleixner , Tony Luck , linux-ia64@vger.kernel.org, linux-mips@linux-mips.org, linuxppc-dev@lists.ozlabs.org, sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org On Wed 05-09-18 18:59:25, Mike Rapoport wrote: > The __alloc_bootmem_node_nopanic() is used only once, there is no reason to > add a wrapper for memblock_alloc_try_nid_nopanic for it. OK, it took me a bit longer to see they are equivalent. Both zero the memory and fallback to a different node if the given one doesn't have a proper range. So good. Lack of proper documentation didn't really help. > Signed-off-by: Mike Rapoport Acked-by: Michal Hocko > --- > arch/x86/kernel/setup_percpu.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/arch/x86/kernel/setup_percpu.c b/arch/x86/kernel/setup_percpu.c > index ea554f8..67d48e26 100644 > --- a/arch/x86/kernel/setup_percpu.c > +++ b/arch/x86/kernel/setup_percpu.c > @@ -112,8 +112,10 @@ static void * __init pcpu_alloc_bootmem(unsigned int cpu, unsigned long size, > pr_debug("per cpu data for cpu%d %lu bytes at %016lx\n", > cpu, size, __pa(ptr)); > } else { > - ptr = __alloc_bootmem_node_nopanic(NODE_DATA(node), > - size, align, goal); > + ptr = memblock_alloc_try_nid_nopanic(size, align, goal, > + BOOTMEM_ALLOC_ACCESSIBLE, > + node); > + > pr_debug("per cpu data for cpu%d %lu bytes on node%d at %016lx\n", > cpu, size, node, __pa(ptr)); > } > -- > 2.7.4 -- Michal Hocko SUSE Labs