From: Andrew Morton <akpm@linux-foundation.org>
To: Huang Ying <ying.huang@intel.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Dave Hansen <dave.hansen@linux.intel.com>,
Michal Hocko <mhocko@suse.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Shaohua Li <shli@kernel.org>, Hugh Dickins <hughd@google.com>,
Minchan Kim <minchan@kernel.org>
Subject: Re: [PATCH 1/3] swap: Use __try_to_reclaim_swap() in free_swap_and_cache()
Date: Mon, 27 Aug 2018 15:44:37 -0700 [thread overview]
Message-ID: <20180827154437.f48115fb23cc214b76bee97d@linux-foundation.org> (raw)
In-Reply-To: <20180827075535.17406-2-ying.huang@intel.com>
On Mon, 27 Aug 2018 15:55:33 +0800 Huang Ying <ying.huang@intel.com> wrote:
> The code path to reclaim the swap entry in free_swap_and_cache() is
> almost same as that of __try_to_reclaim_swap(). The largest
> difference is just coding style. So the support to the additional
> requirement of free_swap_and_cache() is added into
> __try_to_reclaim_swap(). free_swap_and_cache() is changed to call
> __try_to_reclaim_swap(), and delete the duplicated code. This will
> improve code readability and reduce the potential bugs.
>
> There are 2 functionality differences between __try_to_reclaim_swap()
> and swap entry reclaim code of free_swap_and_cache().
>
> - free_swap_and_cache() only reclaims the swap entry if the page is
> unmapped or swap is getting full. The support has been added into
> __try_to_reclaim_swap().
>
> - try_to_free_swap() (called by __try_to_reclaim_swap()) checks
> pm_suspended_storage(), while free_swap_and_cache() not. I think
> this is OK. Because the page and the swap entry can be reclaimed
> later eventually.
hm. Having functions take `mode' arguments which specify their actions
in this manner isn't popular (Linus ;)) but I guess the end result is
somewhat better.
next prev parent reply other threads:[~2018-08-27 22:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-27 7:55 [PATCH 0/3] swap: Code refactoring for some swap free related functions Huang Ying
2018-08-27 7:55 ` [PATCH 1/3] swap: Use __try_to_reclaim_swap() in free_swap_and_cache() Huang Ying
2018-08-27 22:44 ` Andrew Morton [this message]
2018-08-27 7:55 ` [PATCH 2/3] swap: call free_swap_slot() in __swap_entry_free() Huang Ying
2018-08-27 7:55 ` [PATCH 3/3] swap: Clear si->swap_map[] in swap_free_cluster() Huang Ying
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180827154437.f48115fb23cc214b76bee97d@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=dave.hansen@linux.intel.com \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=minchan@kernel.org \
--cc=shli@kernel.org \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox