From: Catalin Marinas <catalin.marinas@arm.com>
To: Vincent Whitchurch <vincent.whitchurch@axis.com>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, Vincent Whitchurch <rabinv@axis.com>
Subject: Re: [PATCH] kmemleak: Always register debugfs file
Date: Fri, 24 Aug 2018 16:23:46 +0100 [thread overview]
Message-ID: <20180824152345.hebdwpatberaah3a@armageddon.cambridge.arm.com> (raw)
In-Reply-To: <20180824131220.19176-1-vincent.whitchurch@axis.com>
On Fri, Aug 24, 2018 at 03:12:20PM +0200, Vincent Whitchurch wrote:
> If kmemleak built in to the kernel, but is disabled by default, the
> debugfs file is never registered. Because of this, it is not possible
> to find out if the kernel is built with kmemleak support by checking for
> the presence of this file. To allow this, always register the file.
>
> After this patch, if the file doesn't exist, kmemleak is not available
> in the kernel. If writing "scan" or any other value than "clear" to
> this file results in EBUSY, then kmemleak is available but is disabled
> by default and can be activated via the kernel command line.
>
> Signed-off-by: Vincent Whitchurch <vincent.whitchurch@axis.com>
I think that's also consistent with a late disabling of kmemleak when
the debugfs entry sticks around.
Acked-by: Catalin Marinas <catalin.marinas@arm.com>
prev parent reply other threads:[~2018-08-24 15:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-24 13:12 Vincent Whitchurch
2018-08-24 15:23 ` Catalin Marinas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180824152345.hebdwpatberaah3a@armageddon.cambridge.arm.com \
--to=catalin.marinas@arm.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rabinv@axis.com \
--cc=vincent.whitchurch@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox