From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-it0-f72.google.com (mail-it0-f72.google.com [209.85.214.72]) by kanga.kvack.org (Postfix) with ESMTP id D177B6B2E9B for ; Fri, 24 Aug 2018 04:06:36 -0400 (EDT) Received: by mail-it0-f72.google.com with SMTP id m207-v6so742750itg.5 for ; Fri, 24 Aug 2018 01:06:36 -0700 (PDT) Received: from merlin.infradead.org (merlin.infradead.org. [2001:8b0:10b:1231::1]) by mx.google.com with ESMTPS id a25-v6si4769069jak.108.2018.08.24.01.06.34 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 24 Aug 2018 01:06:34 -0700 (PDT) Date: Fri, 24 Aug 2018 10:05:48 +0200 From: Peter Zijlstra Subject: Re: [RFC PATCH 0/2] minor mmu_gather patches Message-ID: <20180824080548.GH24124@hirez.programming.kicks-ass.net> References: <20180823084709.19717-1-npiggin@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: owner-linux-mm@kvack.org List-ID: To: Linus Torvalds Cc: Nick Piggin , Andrew Lutomirski , the arch/x86 maintainers , Borislav Petkov , Will Deacon , Rik van Riel , Jann Horn , Adin Scannell , Dave Hansen , Linux Kernel Mailing List , linux-mm , David Miller , Martin Schwidefsky , Michael Ellerman , linux-arch On Thu, Aug 23, 2018 at 12:15:37PM -0700, Linus Torvalds wrote: > PeterZ - your "mm/tlb, x86/mm: Support invalidating TLB caches for > RCU_TABLE_FREE" patch looks exactly the same, but it now no longer has > the split of tlb_flush_mmu_tlbonly(), since with Nick's patch to move > the call to tlb_table_flush(tlb) into tlb_flush_mmu_free, there's no > need for the separate double-underscore version. > > I hope nothing I did screwed things up. It all looks sane to me. > Famous last words. Sorry; I got distracted by building a bunk bed for the kids -- and somehow these things always take way more time than expected. Anyway, the code looks good to me. Thanks all!