From: Michal Hocko <mhocko@kernel.org>
To: Mike Kravetz <mike.kravetz@oracle.com>
Cc: "kbuild test robot" <lkp@intel.com>,
kbuild-all@01.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org,
"Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
"Jérôme Glisse" <jglisse@redhat.com>,
"Vlastimil Babka" <vbabka@suse.cz>,
"Naoya Horiguchi" <n-horiguchi@ah.jp.nec.com>,
"Davidlohr Bueso" <dave@stgolabs.net>,
"Andrew Morton" <akpm@linux-foundation.org>,
stable@vger.kernel.org
Subject: Re: [PATCH v3 1/2] mm: migration: fix migration of huge PMD shared pages
Date: Thu, 23 Aug 2018 14:48:55 +0200 [thread overview]
Message-ID: <20180823124855.GI29735@dhcp22.suse.cz> (raw)
In-Reply-To: <975b740d-26a6-eb3f-c8ca-1a9995d0d343@oracle.com>
On Tue 21-08-18 18:10:42, Mike Kravetz wrote:
[...]
OK, after burning myself when trying to be clever here it seems like
your proposed solution is indeed simpler.
> +bool huge_pmd_sharing_possible(struct vm_area_struct *vma,
> + unsigned long *start, unsigned long *end)
> +{
> + unsigned long check_addr = *start;
> + bool ret = false;
> +
> + if (!(vma->vm_flags & VM_MAYSHARE))
> + return ret;
> +
> + for (check_addr = *start; check_addr < *end; check_addr += PUD_SIZE) {
> + unsigned long a_start = check_addr & PUD_MASK;
> + unsigned long a_end = a_start + PUD_SIZE;
I guess this should be rather in HPAGE_SIZE * PTRS_PER_PTE units as
huge_pmd_unshare does.
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2018-08-23 12:48 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-21 20:59 [PATCH v3 0/2] huge_pmd_unshare migration and flushing Mike Kravetz
2018-08-21 20:59 ` [PATCH v3 1/2] mm: migration: fix migration of huge PMD shared pages Mike Kravetz
2018-08-21 22:03 ` kbuild test robot
2018-08-21 23:06 ` Mike Kravetz
2018-08-22 0:51 ` kbuild test robot
2018-08-22 1:10 ` Mike Kravetz
2018-08-22 12:28 ` Michal Hocko
2018-08-22 16:48 ` Mike Kravetz
2018-08-23 7:30 ` Michal Hocko
2018-08-23 8:21 ` Kirill A. Shutemov
2018-08-23 10:33 ` Michal Hocko
2018-08-23 16:45 ` Mike Kravetz
2018-08-22 21:05 ` Kirill A. Shutemov
2018-08-22 21:48 ` Mike Kravetz
2018-08-23 12:48 ` Michal Hocko [this message]
2018-08-23 17:01 ` Mike Kravetz
2018-08-23 17:56 ` Mike Kravetz
2018-08-23 19:36 ` Michal Hocko
2018-08-21 20:59 ` [PATCH v3 2/2] hugetlb: take PMD sharing into account when flushing tlb/caches Mike Kravetz
2018-08-21 23:07 ` kbuild test robot
2018-08-22 1:20 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180823124855.GI29735@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=dave@stgolabs.net \
--cc=jglisse@redhat.com \
--cc=kbuild-all@01.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
--cc=mike.kravetz@oracle.com \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=stable@vger.kernel.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox