From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by kanga.kvack.org (Postfix) with ESMTP id 12B786B1B59 for ; Mon, 20 Aug 2018 18:04:26 -0400 (EDT) Received: by mail-wr1-f69.google.com with SMTP id k44-v6so4541293wre.21 for ; Mon, 20 Aug 2018 15:04:26 -0700 (PDT) Received: from one.firstfloor.org (one.firstfloor.org. [193.170.194.197]) by mx.google.com with ESMTPS id g8-v6si7721475wru.338.2018.08.20.15.04.24 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 20 Aug 2018 15:04:24 -0700 (PDT) Date: Mon, 20 Aug 2018 15:04:23 -0700 From: Andi Kleen Subject: Re: [PATCH] x86/mm: Simplify p[g4um]d_page() macros Message-ID: <20180820220422.7qrayn7wivmejr24@two.firstfloor.org> References: <20180820203705.16212-1-andi@firstfloor.org> <20180820203705.16212-2-andi@firstfloor.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: owner-linux-mm@kvack.org List-ID: To: Linus Torvalds Cc: Andi Kleen , stable , Andi Kleen , Tom Lendacky , Alexander Potapenko , Andrey Ryabinin , Andrew Lutomirski , Arnd Bergmann , Borislav Petkov , Brijesh Singh , Dave Young , Dmitry Vyukov , Jonathan Corbet , Konrad Rzeszutek Wilk , Larry Woodman , Matt Fleming , "Michael S. Tsirkin" , Paolo Bonzini , Peter Zijlstra , Radim =?utf-8?B?S3LEjW3DocWZ?= , Rik van Riel , Toshi Kani , kasan-dev , KVM list , linux-arch , "open list:DOCUMENTATION" , linux-efi , linux-mm , Ingo Molnar On Mon, Aug 20, 2018 at 02:57:39PM -0700, Linus Torvalds wrote: > On Mon, Aug 20, 2018 at 1:37 PM Andi Kleen wrote: > > > > From: Andi Kleen > > > > Create a pgd_pfn() macro similar to the p[4um]d_pfn() macros and then > > use the p[g4um]d_pfn() macros in the p[g4um]d_page() macros instead of > > duplicating the code. > > When doing backports, _please_ explicitly specify which commit this is > upstream too. Ok. > > Also, the original upstream patch is credited to Tom Lendacky. Okay. > > Or is there something I'm not seeing, and this is different from > commit fd7e315988b7 ("x86/mm: Simplify p[g4um]d_page() macros")? No it's Tom's patch just ported to the older tree with some minor changes. I just fat fingered it while doing the commit -Andi