From: Pasha Tatashin <Pavel.Tatashin@microsoft.com>
To: Oscar Salvador <osalvador@techadventures.net>
Cc: Andrew Morton <akpm@linux-foundation.org>,
"mhocko@suse.com" <mhocko@suse.com>,
"vbabka@suse.cz" <vbabka@suse.cz>,
"dan.j.williams@intel.com" <dan.j.williams@intel.com>,
"yasu.isimatu@gmail.com" <yasu.isimatu@gmail.com>,
"jonathan.cameron@huawei.com" <jonathan.cameron@huawei.com>,
"david@redhat.com" <david@redhat.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Oscar Salvador <osalvador@suse.de>
Subject: Re: [PATCH v3 3/4] mm/memory_hotplug: Refactor unregister_mem_sect_under_nodes
Date: Thu, 16 Aug 2018 18:22:21 +0000 [thread overview]
Message-ID: <20180816182220.dmlun5edcbf4lspj@xakep.localdomain> (raw)
In-Reply-To: <20180816074813.GA16221@techadventures.net>
> > d) What's the maximum number of nodes, ever? Perhaps we can always
> > fit a nodemask_t onto the stack, dunno.
>
> Right now, we define the maximum as NODES_SHIFT = 10, so:
>
> 1 << 10 = 1024 Maximum nodes.
>
> Since this makes only 128 bytes, I wonder if we can just go ahead and define a nodemask_t
> whithin the stack.
> 128 bytes is not that much, is it?
Yeah, sue stack here, 128b is tiny. This also will solve Andrew's point of having an untested path when alloc fails, and simplify the patch overall.
Thank you,
Pavel
next prev parent reply other threads:[~2018-08-16 18:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-15 14:42 [PATCH v3 0/4] Refactoring for remove_memory_section/unregister_mem_sect_under_nodes Oscar Salvador
2018-08-15 14:42 ` [PATCH v3 1/4] mm/memory-hotplug: Drop unused args from remove_memory_section Oscar Salvador
2018-08-16 17:45 ` Pasha Tatashin
2018-08-15 14:42 ` [PATCH v3 2/4] mm/memory_hotplug: Drop mem_blk check from unregister_mem_sect_under_nodes Oscar Salvador
2018-08-16 17:53 ` Pasha Tatashin
2018-08-16 18:43 ` David Hildenbrand
2018-08-15 14:42 ` [PATCH v3 3/4] mm/memory_hotplug: Refactor unregister_mem_sect_under_nodes Oscar Salvador
2018-08-15 22:01 ` Andrew Morton
2018-08-16 7:48 ` Oscar Salvador
2018-08-16 18:22 ` Pasha Tatashin [this message]
2018-08-15 14:42 ` [PATCH v3 4/4] mm/memory_hotplug: Drop node_online check in unregister_mem_sect_under_nodes Oscar Salvador
2018-08-16 18:43 ` David Hildenbrand
2018-08-16 18:59 ` Pasha Tatashin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180816182220.dmlun5edcbf4lspj@xakep.localdomain \
--to=pavel.tatashin@microsoft.com \
--cc=akpm@linux-foundation.org \
--cc=dan.j.williams@intel.com \
--cc=david@redhat.com \
--cc=jonathan.cameron@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=osalvador@suse.de \
--cc=osalvador@techadventures.net \
--cc=vbabka@suse.cz \
--cc=yasu.isimatu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox